You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mkoltsov <gi...@git.apache.org> on 2015/06/28 01:15:23 UTC
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
GitHub user mkoltsov opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/126
started to make grunt more happy
started migration to use autoreload (and automatic re-run of build pipeline) in grunt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkoltsov/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit a125138bb9e350f7a1fe106819315d3b2f85a9a0
Author: mkoltsov <ro...@javabean.ru>
Date: 2015-06-26T23:10:04Z
started to make grunt more happy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/126#issuecomment-116485743
If your PR stops here, then maybe you can change the description to:
Code Style fixing and small code refactoring (since there is no work on grunt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/126#issuecomment-116366266
The description is a bit misleading I guess.
But, code Improvement is always welcome.
I see that you fixed some coding style problems and refactored some code to make it smaller.
I actually didn't know about the double ! operator: http://stackoverflow.com/questions/784929/what-is-the-not-not-operator-in-javascript
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
Posted by mkoltsov <gi...@git.apache.org>.
Github user mkoltsov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/126#issuecomment-116354630
Do I need a better description for this PR to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
Posted by mkoltsov <gi...@git.apache.org>.
Github user mkoltsov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/126#issuecomment-116361579
Absolutely! My intent was to fix some of the problems that Grunt rants about and to make a small refactoring (like checking equality with 'undifined'). I didn't know what is your PR policy in this project and in case you are fine with such small improvements I can spread it on a bigger chunk of frontend.
We use Zeppelin in our company and I would like to contribute back!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
Posted by mkoltsov <gi...@git.apache.org>.
Github user mkoltsov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/126#issuecomment-116475164
Do I need to modify description somehow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/126#issuecomment-116360472
Thanks for making pullrequest.
Could you explain little bit more about do you want to deal with "autoreload (and automatic re-run of build pipeline) in grunt"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Code Style fixing and small code ...
Posted by mkoltsov <gi...@git.apache.org>.
Github user mkoltsov closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: started to make grunt more happy
Posted by mkoltsov <gi...@git.apache.org>.
Github user mkoltsov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/126#issuecomment-116490869
Thank you for suggestion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---