You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/19 10:02:05 UTC
[GitHub] [inlong] thesumery opened a new pull request, #6225: [INLONG-6214][Sort] Import schema and data parsing ability for DynamicSchemaFormat
thesumery opened a new pull request, #6225:
URL: https://github.com/apache/inlong/pull/6225
[INLONG-6214][Sort] Import schema and data parsing ability for DynamicSchemaFormat
### Prepare a Pull Request
- [INLONG-6214][Sort] Import schema and data parsing ability for DynamicSchemaFormat
- Fixes #6214
### Motivation
*Import schema and data parsing ability for DynamicSchemaFormat*
### Modifications
*Import schema and data parsing ability for DynamicSchemaFormat*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #6225: [INLONG-6214][Sort] Import schema and data parsing ability for DynamicSchemaFormat
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #6225:
URL: https://github.com/apache/inlong/pull/6225#discussion_r1000096769
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/DebeziumJsonDynamicSchemaFormat.java:
##########
@@ -69,6 +81,49 @@ public List<String> extractPrimaryKeyNames(JsonNode data) {
return pkNames;
}
+ @Override
+ public boolean extractDDLFlag(JsonNode data) {
+ return data.has(DDL_FLAG) ? data.get(DDL_FLAG).asBoolean(false) : false;
+ }
+
+ @Override
+ public RowType extractSchema(JsonNode data, List<String> pkNames) {
+ JsonNode schema = data.get(SCHEMA);
Review Comment:
there should be a scheam info for extract RowType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu merged pull request #6225: [INLONG-6214][Sort] Import schema and data parsing ability for DynamicSchemaFormat
Posted by GitBox <gi...@apache.org>.
yunqingmoswu merged PR #6225:
URL: https://github.com/apache/inlong/pull/6225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #6225: [INLONG-6214][Sort] Import schema and data parsing ability for DynamicSchemaFormat
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #6225:
URL: https://github.com/apache/inlong/pull/6225#discussion_r999379824
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/DebeziumJsonDynamicSchemaFormat.java:
##########
@@ -69,6 +81,49 @@ public List<String> extractPrimaryKeyNames(JsonNode data) {
return pkNames;
}
+ @Override
+ public boolean extractDDLFlag(JsonNode data) {
+ return data.has(DDL_FLAG) ? data.get(DDL_FLAG).asBoolean(false) : false;
+ }
+
+ @Override
+ public RowType extractSchema(JsonNode data, List<String> pkNames) {
+ JsonNode schema = data.get(SCHEMA);
Review Comment:
Does sqlType exist in standard debezium json? What shoud do if it is not exists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org