You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/01/11 13:41:29 UTC
[GitHub] asfgit closed pull request #5801: IGNITE-9859 Add debug logging on
refreshPartitions cause
asfgit closed pull request #5801: IGNITE-9859 Add debug logging on refreshPartitions cause
URL: https://github.com/apache/ignite/pull/5801
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
index d2304d44bd2e..525c41afb93a 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
@@ -44,6 +44,7 @@
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.IgniteLogger;
import org.apache.ignite.IgniteSystemProperties;
import org.apache.ignite.cache.affinity.AffinityFunction;
import org.apache.ignite.cluster.ClusterNode;
@@ -1104,6 +1105,9 @@ public void scheduleResendPartitions() {
public void refreshPartitions(@NotNull Collection<CacheGroupContext> grps) {
// TODO https://issues.apache.org/jira/browse/IGNITE-6857
if (cctx.snapshot().snapshotOperationInProgress()) {
+ if (log.isDebugEnabled())
+ log.debug("Schedule resend parititions due to snapshot in progress");
+
scheduleResendPartitions();
return;
@@ -1709,8 +1713,12 @@ else if (!grp.isLocal())
}
}
- if (!cctx.kernalContext().clientNode() && updated)
+ if (!cctx.kernalContext().clientNode() && updated) {
+ if (log.isDebugEnabled())
+ log.debug("Refresh partitions due to topology update");
+
refreshPartitions();
+ }
boolean hasMovingParts = false;
@@ -2973,8 +2981,12 @@ else if (task instanceof ForceRebalanceExchangeTask) {
changed |= grp.topology().afterExchange(exchFut);
}
- if (!cctx.kernalContext().clientNode() && changed && !hasPendingServerExchange())
+ if (!cctx.kernalContext().clientNode() && changed && !hasPendingServerExchange()) {
+ if (log.isDebugEnabled())
+ log.debug("Refresh partitions due to mapping was changed");
+
refreshPartitions();
+ }
}
// Schedule rebalance if force rebalance or force reassign occurs.
@@ -3137,12 +3149,22 @@ else if (r != null) {
/** Timeout ID. */
private final IgniteUuid timeoutId = IgniteUuid.randomUuid();
+ /** Logger. */
+ protected final IgniteLogger log;
+
/** Timeout start time. */
private final long createTime = U.currentTimeMillis();
/** Started flag. */
private AtomicBoolean started = new AtomicBoolean();
+ /**
+ *
+ */
+ private ResendTimeoutObject() {
+ this.log = cctx.logger(getClass());
+ }
+
/** {@inheritDoc} */
@Override public IgniteUuid timeoutId() {
return timeoutId;
@@ -3161,8 +3183,12 @@ else if (r != null) {
return;
try {
- if (started.compareAndSet(false, true))
+ if (started.compareAndSet(false, true)) {
+ if (log.isDebugEnabled())
+ log.debug("Refresh partitions due to scheduled timeout");
+
refreshPartitions();
+ }
}
finally {
busyLock.readLock().unlock();
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/WalStateManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/WalStateManager.java
index 83c548ea93d8..9d962db5d958 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/WalStateManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/WalStateManager.java
@@ -514,6 +514,9 @@ else if (log.isDebugEnabled())
}
+ if (log.isDebugEnabled())
+ log.debug("Refresh partitions due to rebalance finished");
+
cctx.exchange().refreshPartitions();
}
});
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
index b53fe99e5ab4..bce239c375dd 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
@@ -2118,8 +2118,13 @@ private String exchangeTimingsLogMessage(String header, List<String> timings) {
}
- if (!grpToRefresh.isEmpty())
+ if (!grpToRefresh.isEmpty()){
+ if (log.isDebugEnabled())
+ log.debug("Refresh partitions due to partitions initialized when affinity ready [" +
+ grpToRefresh.stream().map(CacheGroupContext::name).collect(Collectors.toList()) + ']');
+
cctx.exchange().refreshPartitions(grpToRefresh);
+ }
}
for (GridCacheContext cacheCtx : cctx.cacheContexts()) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services