Re: [PR] [SPARK-47799][BUILD] Add `-g` to javac compile parameters when using SBT package jar [spark]

["cxzl25 (via GitHub)" <gi...@apache.org>]

cxzl25 commented on code in PR #45983:
URL: https://github.com/apache/spark/pull/45983#discussion_r1560761758


##########
project/SparkBuild.scala:
##########
@@ -311,6 +311,7 @@ object SparkBuild extends PomBuild {
 
     (Compile / javacOptions) ++= Seq(
       "-encoding", UTF_8.name(),
+      "-g",

Review Comment:
   >  we need to revise the PR title
   
   OK
   
   > but it's still smaller than Maven-generated size
   
   In this PR, the main difference between the two is the META-INF folder, maven generated more information, but SBT did not.
   
   
   <img width="251" alt="image" src="https://github.com/apache/spark/assets/3898450/8e2466ac-9962-4c96-a4e5-70cf59bf9dc3">
   
   
   <img width="1017" alt="image" src="https://github.com/apache/spark/assets/3898450/28d038cd-5949-485a-bf9d-0c8b1edbfdfe">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org