[GitHub] [hudi] xushiyan commented on a diff in pull request #5651: [WIP][MINOR] Add OperationField's enable to table config

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #5651:
URL: https://github.com/apache/hudi/pull/5651#discussion_r882668379


##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -234,6 +234,13 @@ public class HoodieTableConfig extends HoodieConfig {
       .withDocumentation("Comma-separated list of metadata partitions that have been completely built and in-sync with data table. "
           + "These partitions are ready for use by the readers");
 
+  public static final ConfigProperty<Boolean> ALLOW_OPERATION_METADATA_FIELD = ConfigProperty
+      .key("hoodie.allow.operation.metadata.field")
+      .defaultValue(false)
+      .sinceVersion("0.11.1")

Review Comment:
   to users, this config has been there since 0.9.0, as the key did not change



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -456,13 +456,6 @@ public class HoodieWriteConfig extends HoodieConfig {
       .withDocumentation("Whether to allow generation of empty commits, even if no data was written in the commit. "
           + "It's useful in cases where extra metadata needs to be published regardless e.g tracking source offsets when ingesting data");
 
-  public static final ConfigProperty<Boolean> ALLOW_OPERATION_METADATA_FIELD = ConfigProperty
-      .key("hoodie.allow.operation.metadata.field")
-      .defaultValue(false)
-      .sinceVersion("0.9.0")
-      .withDocumentation("Whether to include '_hoodie_operation' in the metadata fields. "
-          + "Once enabled, all the changes of a record are persisted to the delta log directly without merge");

Review Comment:
   @XuQianJin-Stars  can you help me understand the main problem of the config staying in write config? Also, for user-facing config change, can we please file jira for tracking?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org