You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/04 04:01:06 UTC
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#16922: Update LoggingHandler to support logging per interval
leezu commented on a change in pull request #16922: Update LoggingHandler to support logging per interval
URL: https://github.com/apache/incubator-mxnet/pull/16922#discussion_r353539859
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -241,17 +241,16 @@ class LoggingHandler(TrainBegin, TrainEnd, EpochBegin, EpochEnd, BatchBegin, Bat
"""
LOG_PER_EPOCH = 1
- LOG_PER_BATCH = 2
- LOG_PER_INTERVAL = 3
+ LOG_PER_INTERVAL = 2
def __init__(self, verbose=LOG_PER_EPOCH,
train_metrics=None,
val_metrics=None,
log_interval=1):
Review comment:
Do you think it would make sense to drop the `verbose` argument completely? For example, if `log_interval=None`, we only log per epoch. If log_interval is set to any positive integer, we log according to that interval?
For example, the following constructor:
```
def __init__(self, log_interval=None,
train_metrics=None,
val_metrics=None):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services