You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Greg Thompson (JIRA)" <ji...@codehaus.org> on 2007/11/16 20:35:26 UTC
[jira] Created: (MJAVADOC-162) javadocExecutable unusable
javadocExecutable unusable
--------------------------
Key: MJAVADOC-162
URL: http://jira.codehaus.org/browse/MJAVADOC-162
Project: Maven 2.x Javadoc Plugin
Issue Type: Bug
Affects Versions: 2.3
Environment: Windows XP and non-Windows
Reporter: Greg Thompson
AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:
<javadocExecutable>blahblahblah${file.separator}javadoc</javadocExecutable>
then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.
If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.
Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.
Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MJAVADOC-162) javadocExecutable unusable
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAVADOC-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MJAVADOC-162:
---------------------------------------
Attachment: javadoc-executable.patch
Patch attached. The logic has been extended to accept "<snip>/javadoc" on all platforms by appending ".exe" automatically on Windows boxes.
Besides the fix, I made the parameter accept a mere directory spec, too, as a matter of convenience.
> javadocExecutable unusable
> --------------------------
>
> Key: MJAVADOC-162
> URL: http://jira.codehaus.org/browse/MJAVADOC-162
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Environment: Windows XP and non-Windows
> Reporter: Greg Thompson
> Attachments: javadoc-executable.patch
>
>
> AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:
> <javadocExecutable>blahblahblah${file.separator}javadoc</javadocExecutable>
> then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.
> If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.
> Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.
> Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MJAVADOC-162) javadocExecutable unusable
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAVADOC-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MJAVADOC-162.
--------------------------------------
Assignee: Benjamin Bentmann
Resolution: Fixed
Fix Version/s: 2.5
Fixed in [r649582|http://svn.apache.org/viewvc?view=rev&revision=649582].
> javadocExecutable unusable
> --------------------------
>
> Key: MJAVADOC-162
> URL: http://jira.codehaus.org/browse/MJAVADOC-162
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Environment: Windows XP and non-Windows
> Reporter: Greg Thompson
> Assignee: Benjamin Bentmann
> Fix For: 2.5
>
> Attachments: javadoc-executable.patch
>
>
> AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:
> <javadocExecutable>blahblahblah${file.separator}javadoc</javadocExecutable>
> then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.
> If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.
> Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.
> Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-162) javadocExecutable unusable
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAVADOC-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126243 ]
Wendy Smoak commented on MJAVADOC-162:
--------------------------------------
Vincent, you marked this for 2.4 back in January. Are you planning to work on it, or should we bump it to 2.5? I'd like to stage 2.4 this weekend.
> javadocExecutable unusable
> --------------------------
>
> Key: MJAVADOC-162
> URL: http://jira.codehaus.org/browse/MJAVADOC-162
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Environment: Windows XP and non-Windows
> Reporter: Greg Thompson
> Fix For: 2.4
>
>
> AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:
> <javadocExecutable>blahblahblah${file.separator}javadoc</javadocExecutable>
> then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.
> If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.
> Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.
> Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MJAVADOC-162) javadocExecutable unusable
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAVADOC-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Smoak updated MJAVADOC-162:
---------------------------------
Fix Version/s: (was: 2.4)
> javadocExecutable unusable
> --------------------------
>
> Key: MJAVADOC-162
> URL: http://jira.codehaus.org/browse/MJAVADOC-162
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Environment: Windows XP and non-Windows
> Reporter: Greg Thompson
>
> AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:
> <javadocExecutable>blahblahblah${file.separator}javadoc</javadocExecutable>
> then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.
> If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.
> Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.
> Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MJAVADOC-162) javadocExecutable unusable
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAVADOC-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton updated MJAVADOC-162:
-------------------------------------
Fix Version/s: 2.4
> javadocExecutable unusable
> --------------------------
>
> Key: MJAVADOC-162
> URL: http://jira.codehaus.org/browse/MJAVADOC-162
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Environment: Windows XP and non-Windows
> Reporter: Greg Thompson
> Fix For: 2.4
>
>
> AbstractJavadocMojo tries to be smart by seeing if the file indicated by javadocExecutable exists, but this is actually quite problematic. If you put the following in your config:
> <javadocExecutable>blahblahblah${file.separator}javadoc</javadocExecutable>
> then you'll get an error on Windows since the file is actually javadoc.exe, which is a pain since it's perfectly acceptable to omit the .exe when executing a command.
> If you put .exe in the config, then it won't work on non-Windows platforms since the files doesn't have .exe.
> Forcing users to add hackery to their POMs to add .exe in some cases and leave it off in others is onerous.
> Methinks it's much preferable to simply use the path provided by the config. If it doesn't exist, let CommandLineUtils.executeCommandLine (or something else) throw an exception.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira