[GitHub] [jmeter] vlsi commented on a diff in pull request #5785: Fix InfluxDBRawBackendListenerClient missing data

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on code in PR #5785:
URL: https://github.com/apache/jmeter/pull/5785#discussion_r1198899521


##########
src/components/src/main/java/org/apache/jmeter/visualizers/backend/influxdb/InfluxDBRawBackendListenerClient.java:
##########
@@ -122,8 +122,10 @@ private String createTags(SampleResult sampleResult) {
         // remove surrounding quotes and spaces from sample label
         String label = StringUtils.strip(sampleResult.getSampleLabel(), "\" ");
         String transaction = AbstractInfluxdbMetricsSender.tagToStringValue(label);
+        String threadName = StringUtils.deleteWhitespace(sampleResult.getThreadName());

Review Comment:
   This might be time-consuming.
   Do you really need a thread name?
   Would it be workable if we included a "unique thread id"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org