[GitHub] [arrow] rok commented on a diff in pull request #13409: ARROW-16616: [Python] Lazy datasets filtering

[GitBox <gi...@apache.org>]

rok commented on code in PR #13409:
URL: https://github.com/apache/arrow/pull/13409#discussion_r913651121


##########
cpp/src/arrow/compute/exec/options.cc:
##########
@@ -61,5 +61,16 @@ Result<std::shared_ptr<SourceNodeOptions>> SourceNodeOptions::FromTable(
       new SourceNodeOptions(table.schema(), batch_gen));
 }
 
+Result<std::shared_ptr<SourceNodeOptions>> SourceNodeOptions::FromRecordBatchReader(
+    std::shared_ptr<RecordBatchReader> reader, std::shared_ptr<Schema> schema,
+    arrow::internal::Executor* exc) {

Review Comment:
   Just a nit, but `executor` is used elsewhere in the codebase.
   ```suggestion
       arrow::internal::Executor* executor) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org