[GitHub] [ozone] fapifta commented on pull request #3267: HDDS-6209. EC: [Forward compatibility issue] New client to older server could fail due to the unavailability for client default replication config

[GitBox <gi...@apache.org>]

fapifta commented on PR #3267:
URL: https://github.com/apache/ozone/pull/3267#issuecomment-1088319010

   Thanks @errose28 for the initial review. We have some tests in the xcompat test, and also the generic ec tests are flowing through these logic. I would say the happy path scenarios are tested already with the current test set, for the unhappy path scenarios I would love to add tests as part of the refactoring to the new structure, as at that point I can simply write tests just agains the code that is introduced here, and I do not need to worry about setting up a bunch of things.
   
   Also as part of that work I think we have to extend the xcompat tests to test backward and forward compatibility, and after that we can put some EC specific tests as well there.
   I am not sure if this reasoning is good enough, if you think we should write those tests now, I am open to it, just let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org