[GitHub] [tvm] vinx13 commented on a diff in pull request #12618: [TVMScript] support float inf, -inf and nan in TVMScript parser and printer

[GitBox <gi...@apache.org>]

vinx13 commented on code in PR #12618:
URL: https://github.com/apache/tvm/pull/12618#discussion_r956465944


##########
python/tvm/script/tir/intrin.py:
##########
@@ -51,6 +52,13 @@ def bool(imm, span):
             # nest closures so we copy the name string
             def wrap(name):
                 def f(imm, span):
+                    if name.startswith("float"):
+                        if imm == "inf":

Review Comment:
   what's the type of imm? can we do `FloatImm(dtype=name, value=float(imm), span=span)` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org