You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/31 05:50:19 UTC
[GitHub] [incubator-doris] Vikasss7663 opened a new pull request, #9822: [refactor] remove redundant this
Vikasss7663 opened a new pull request, #9822:
URL: https://github.com/apache/incubator-doris/pull/9822
# Proposed changes
Removing redundant this, since it is required mostly in constructor.
Issue Number: #9775
## Problem Summary:
### Before pr:
```
public AlterHandler getSchemaChangeHandler() {
return this.schemaChangeHandler;
}
```
### After pr:
```
public AlterHandler getSchemaChangeHandler() {
return schemaChangeHandler;
}
```
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1140375498
BTW, thought this problom of `this.` exist in many files.
You can just fix 10-20 files rather than so many files which is easier to the first-time contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener closed pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener closed pull request #9822: [refactor] remove redundant this
URL: https://github.com/apache/incubator-doris/pull/9822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141681458
This is what showing
![Uploading Screenshot 2022-05-31 at 10.55.59 AM.pngβ¦]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141697289
When I am trying to create new pull request
<img width="1396" alt="Screenshot 2022-05-31 at 11 27 12 AM" src="https://user-images.githubusercontent.com/98081274/171102871-d4f3c8f0-8799-4652-aea9-58b0f000fd10.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141689334
Now it's ok or not ?
Or I have to create new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141701060
You can recreate a new branch.
Carry this PR's modification in about 10 files to it.
This branch after `git merge` is a little mess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141678326
If you have **good suggestions** than your welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141687120
usually, my behavior.
```bash
# set doris upstream and fetch
git remote add upstream https://github.com/apache/incubator-doris.git
git fetch --all
# rebase to upstream master
git rebase upstream/master
# fix conflict
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1140375305
You can learn knowledge about git.
You can use `git rebase` and `fix conflict`.
Now, this PR include some other PR....π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141691777
You can try
```
git rebase
git push -f
```
in new PR.
It will be better than `git merge`, which can avoid following.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141690204
> Now it's ok or not ?
>
> Or I have to create new PR
You can create a new PR, it's ok and easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141685790
> The one thing now I can do is again create fork and starting all over again.
πIt's ok. A PR with a lot of files has conflicts isn't easy for the newer.
You can create a new PR.
What's more, you also can learn something about `git rebase` and fix conflict, which is useful to your next open-source trip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141678939
are you talking about
fe/fe-core/src/main/java/org/apache/doris/blockrule/SqlBlockRule.java
this files conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 closed pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 closed pull request #9822: [refactor] remove redundant this
URL: https://github.com/apache/incubator-doris/pull/9822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on a diff in pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#discussion_r884133810
##########
fe/fe-core/src/main/java/org/apache/doris/task/AgentBatchTask.java:
##########
@@ -64,7 +64,7 @@ public class AgentBatchTask implements Runnable {
private Map<Long, List<AgentTask>> backendIdToTasks;
public AgentBatchTask() {
- this.backendIdToTasks = new HashMap<Long, List<AgentTask>>();
+ backendIdToTasks = new HashMap<Long, List<AgentTask>>();
Review Comment:
redundant space
##########
fe/fe-core/src/main/java/org/apache/doris/task/AgentBatchTask.java:
##########
@@ -89,8 +89,8 @@ public void addTask(AgentTask agentTask) {
public List<AgentTask> getAllTasks() {
List<AgentTask> tasks = new LinkedList<AgentTask>();
- for (Long backendId : this.backendIdToTasks.keySet()) {
- tasks.addAll(this.backendIdToTasks.get(backendId));
+ for (Long backendId : backendIdToTasks.keySet()) {
+ tasks.addAll( backendIdToTasks.get(backendId));
Review Comment:
same with above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141687832
Some material introduce it. like this
https://www.youtube.com/watch?v=RGtwxYqkkas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1140264358
BTW, please git rebase and fix the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1140389169
I am trying this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on a diff in pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#discussion_r884078005
##########
fe/fe-core/src/main/java/org/apache/doris/backup/AbstractJob.java:
##########
@@ -87,7 +87,7 @@ protected AbstractJob(JobType type, String label, long dbId, String dbName,
this.label = label;
this.dbId = dbId;
this.dbName = dbName;
- this.createTime = System.currentTimeMillis();
Review Comment:
I think `this.` in constructor can remain.
Because I think it's better to keep same style.
##########
fe/fe-core/src/main/java/org/apache/doris/backup/Repository.java:
##########
@@ -119,7 +119,7 @@ public Repository(long id, String name, boolean isReadOnly, String location, Blo
this.isReadOnly = isReadOnly;
this.location = location;
this.storage = storage;
- this.createTime = System.currentTimeMillis();
Review Comment:
same with above.
##########
fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java:
##########
@@ -124,7 +124,7 @@ public BackupJob(String label, long dbId, String dbName, List<TableRef> tableRef
BackupContent content, Catalog catalog, long repoId) {
super(JobType.BACKUP, label, dbId, dbName, timeoutMs, catalog, repoId);
this.tableRefs = tableRefs;
- this.state = BackupJobState.PENDING;
Review Comment:
same with above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1140436354
π new conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141677820
What should I do now ?
I am not able to resolve that conflict issue.
The one thing now I can do is again create fork and starting all over again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9822: [refactor] remove redundant this
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9822:
URL: https://github.com/apache/incubator-doris/pull/9822#issuecomment-1141693188
I forgot it can't comment after close PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org