You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/09/24 10:34:08 UTC
[jira] [Created] (GIRAPH-341) Improved log messages (timing) and
upgraded junit to 4.8 for better tests.
Avery Ching created GIRAPH-341:
----------------------------------
Summary: Improved log messages (timing) and upgraded junit to 4.8 for better tests.
Key: GIRAPH-341
URL: https://issues.apache.org/jira/browse/GIRAPH-341
Project: Giraph
Issue Type: Sub-task
Reporter: Avery Ching
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-341) Improved log messages (timing) and
upgraded junit to 4.8 for better tests.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464550#comment-13464550 ]
Hudson commented on GIRAPH-341:
-------------------------------
Integrated in Giraph-trunk-Commit #210 (See [https://builds.apache.org/job/Giraph-trunk-Commit/210/])
GIRAPH-341: Improved log messages (timing) and upgraded junit to 4.8
for better tests. (Revision 1390885)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390885
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/pom.xml
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/ByteCounter.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/handler/RequestDecoder.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/handler/RequestEncoder.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/handler/RequestInfo.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/handler/ResponseClientHandler.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* /giraph/trunk/src/main/java/org/apache/giraph/utils/FakeTime.java
* /giraph/trunk/src/main/java/org/apache/giraph/utils/SystemTime.java
* /giraph/trunk/src/main/java/org/apache/giraph/utils/Time.java
* /giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
* /giraph/trunk/src/test/java/org/apache/giraph/aggregators/TestDoubleAggregators.java
* /giraph/trunk/src/test/java/org/apache/giraph/aggregators/TestFloatAggregators.java
* /giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java
* /giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
* /giraph/trunk/src/test/java/org/apache/giraph/utils/BspUtilsTest.java
> Improved log messages (timing) and upgraded junit to 4.8 for better tests.
> --------------------------------------------------------------------------
>
> Key: GIRAPH-341
> URL: https://issues.apache.org/jira/browse/GIRAPH-341
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-341.2.patch, GIRAPH-341.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-341) Improved log messages (timing) and
upgraded junit to 4.8 for better tests.
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-341:
-------------------------------
Attachment: GIRAPH-341.patch
Must be applied after GIRAPH-340, ready to go.
> Improved log messages (timing) and upgraded junit to 4.8 for better tests.
> --------------------------------------------------------------------------
>
> Key: GIRAPH-341
> URL: https://issues.apache.org/jira/browse/GIRAPH-341
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Attachments: GIRAPH-341.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-341) Improved log messages (timing) and
upgraded junit to 4.8 for better tests.
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463719#comment-13463719 ]
Alessandro Presta commented on GIRAPH-341:
------------------------------------------
Other than that, it's only some more logging and a perf test, so +1.
(sorry for the double post - I'm too used to Facebook's bindings :( )
> Improved log messages (timing) and upgraded junit to 4.8 for better tests.
> --------------------------------------------------------------------------
>
> Key: GIRAPH-341
> URL: https://issues.apache.org/jira/browse/GIRAPH-341
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-341.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-341) Improved log messages (timing) and
upgraded junit to 4.8 for better tests.
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464548#comment-13464548 ]
Avery Ching commented on GIRAPH-341:
------------------------------------
Committing with [~apresta]'s +1.
> Improved log messages (timing) and upgraded junit to 4.8 for better tests.
> --------------------------------------------------------------------------
>
> Key: GIRAPH-341
> URL: https://issues.apache.org/jira/browse/GIRAPH-341
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-341.2.patch, GIRAPH-341.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-341) Improved log messages (timing) and
upgraded junit to 4.8 for better tests.
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-341:
-------------------------------
Attachment: GIRAPH-341.2.patch
Here's a new version with one minor change to remove getCurrentRequestId().
Agreed that we don't need getCurrentRequestId(). I think I used it for debugging, then removed the line.
Tolerances were for moving to junit 4.8. It is required.
> Improved log messages (timing) and upgraded junit to 4.8 for better tests.
> --------------------------------------------------------------------------
>
> Key: GIRAPH-341
> URL: https://issues.apache.org/jira/browse/GIRAPH-341
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-341.2.patch, GIRAPH-341.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-341) Improved log messages (timing) and
upgraded junit to 4.8 for better tests.
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463716#comment-13463716 ]
Alessandro Presta commented on GIRAPH-341:
------------------------------------------
I'm not sure why the addition of getCurrentRequestId() belongs to this patch (I don't see any usages of it).
Also, why did you have to add 0f as tolerance argument to some assertEquals() calls?
> Improved log messages (timing) and upgraded junit to 4.8 for better tests.
> --------------------------------------------------------------------------
>
> Key: GIRAPH-341
> URL: https://issues.apache.org/jira/browse/GIRAPH-341
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-341.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira