You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/10/18 09:33:07 UTC

[GitHub] [rocketmq] shenhui0509 commented on issue #1516: [ISSUE #1515] SYNC_MASTER could be change into pipeline manner

shenhui0509 commented on issue #1516: [ISSUE #1515] SYNC_MASTER could be change into pipeline manner 
URL: https://github.com/apache/rocketmq/pull/1516#issuecomment-543631363
 
 
   > This PR does improve TPS and reduce latency when synchronized replication (Verified by benchmark). There are some issues：
   > 
   > 1. Transaction message does not seem to work after modification.
   > 2. [DISCUSS] When slave down, master return FLUSH_SLAVE_TIMEOUT instead of SLAVE_NOT_AVALIABLE.
   
   1. I missed msg properties when storage. 
   2. I agree to return SLAVE_NOT_AVAILABLE.
   Both 1 and 2 are fixed, and add some UT and IT for transaction message. Plz take a look at the new commit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services