[jira] [Commented] (SOLR-7112) DeleteInactiveReplicaTest.deleteLiveReplicaTest test failures

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321665#comment-14321665 ] 

Shalin Shekhar Mangar commented on SOLR-7112:
---------------------------------------------

The test method deleteLiveReplicaTest actually belongs to the parent class DeleteReplicaTest.

I think started happening after SOLR-6902. The DeleteInactiveReplicaTest extends the DeleteReplicaTest and used to override the doTest method. After SOLR-6902 we started using annotations and now the test methods in the parent class are also executed as part of this test. But the parent sets sliceCount=2 and sets checkCreatedVsState flag to false which DeleteInactiveReplicaTest doesn't and hence the odd failure.

I'll fix by not inheriting from that class. There's just two methods being shared and they can easily be made package private. A cleanup of these cloud tests is due but that will need it's own issue.

> DeleteInactiveReplicaTest.deleteLiveReplicaTest test failures
> -------------------------------------------------------------
>
>                 Key: SOLR-7112
>                 URL: https://issues.apache.org/jira/browse/SOLR-7112
>             Project: Solr
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 5.0
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Trunk, 5.1
>
>
> {code}
> java.lang.AssertionError: Should have had a good message here
> 	at __randomizedtesting.SeedInfo.seed([E27AFA625D3D168A:4F1A4E694002BEFF]:0)
> 	at org.junit.Assert.fail(Assert.java:93)
> 	at org.junit.Assert.assertTrue(Assert.java:43)
> 	at org.apache.solr.cloud.DeleteReplicaTest.deleteLiveReplicaTest(DeleteReplicaTest.java:125)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
> This fails very frequently on jenkins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org