[jira] [Commented] (MESOS-6709) Port `health_check_tests.cpp`

["Joseph Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868622#comment-15868622 ] 

Joseph Wu commented on MESOS-6709:
----------------------------------

Ported all but two tests (which depend on {{curl}} being on the {{PATH}}):
{code}
commit ddad179ec88a2694d6d63afc3b53db4ac7b3c361
Author: Alex Clemmer <cl...@gmail.com>
Date:   Tue Feb 14 13:16:59 2017 -0800

    Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`.
    
    The `DEV_NULL` constant points to `/dev/null` on Posix and `NUL` on
    Windows.  In both platforms, it can be used to redirect output
    into digital oblivion.
    
    The `TRUE_COMMAND` is a test constant that equals the `true` shell
    command on Posix.  On Windows, we emulate this command by invoking
    a shell with an inline command to exit with a successful exit code.
    
    Review: https://reviews.apache.org/r/55546/

commit c13e2af1dfc982a3b19fb04aa9d3417c1093c7cb
Author: Alex Clemmer <cl...@gmail.com>
Date:   Tue Feb 14 13:40:51 2017 -0800

    Windows: Added health checker to build.
    
    This removes the Windows guard around the health checker CMake build,
    thereby enabling the build of `mesos-tcp-connect` on Windows.
    
    In addition, this replaces some instances of "/dev/null" strings with
    the newly added constant `os::DEV_NULL`.  This is necessary for the
    health checker code to run successfully on Windows.
    
    Review: https://reviews.apache.org/r/55549/

commit 8b18106ea545f0eeab5c7021ef75ffc1dd36ad6f
Author: Alex Clemmer <cl...@gmail.com>
Date:   Tue Feb 14 13:46:15 2017 -0800

    Windows: Enabled health checker tests.
    
    This ports all the health check tests running on Posix to also run
    on Windows, with the exception of two tests that depend on curl binary,
    which is not on the PATH on Windows.
    
    Porting the tests themselves involve replacing some command strings
    with macros or constants and writing a PowerShell version of the
    health check command (one that fails every other invocation).
    
    Review: https://reviews.apache.org/r/55550/
{code}

> Port `health_check_tests.cpp`
> -----------------------------
>
>                 Key: MESOS-6709
>                 URL: https://issues.apache.org/jira/browse/MESOS-6709
>             Project: Mesos
>          Issue Type: Bug
>          Components: agent
>            Reporter: Alex Clemmer
>            Assignee: Alex Clemmer
>              Labels: microsoft, windows-mvp
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)