[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3780: Enhancement: Allow creating atmost 1 physical network with null tag

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3780: Enhancement: Allow creating atmost 1 physical network with null tag
URL: https://github.com/apache/cloudstack/pull/3780#discussion_r373135619
 
 

 ##########
 File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
 ##########
 @@ -3983,6 +4024,13 @@ public PhysicalNetworkTrafficType addTrafficTypeToPhysicalNetwork(Long physicalN
             }
         }
 
+        // Check if there are more than 1 physical network with null tags in same traffic type.
+        // If so then dont allow to add traffic type.
+        List<String> tags = network.getTags();
+        if (tags == null || tags.size() == 0) {
+            checkForPhysicalNetworksWithoutTag(network, trafficType);
+        }
 
 Review comment:
   method call

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services