You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by GitBox <gi...@apache.org> on 2021/08/23 07:22:23 UTC

[GitHub] [oodt] pavinduLakshan commented on a change in pull request #128: [OODT-1035][OODT-1037] Improve UI/UX of Workflow Manager Components in React.js OPSUI

pavinduLakshan commented on a change in pull request #128:
URL: https://github.com/apache/oodt/pull/128#discussion_r693722112



##########
File path: webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowInstanceResource.java
##########
@@ -56,10 +56,12 @@ public WorkflowInstanceResource(WorkflowInstance workflowInstance) {
     this.workflowInstanceId = workflowInstance.getId();
     this.currentTaskId = workflowInstance.getCurrentTaskId();
     this.startDate = workflowInstance.getStartDate().toString();
-    this.endDate = workflowInstance.getEndDate().toString();
     this.timesBlocked = workflowInstance.getTimesBlocked();
     this.sharedContext = new MetadataResource(workflowInstance.getSharedContext());
     this.workflowState = new WorkflowStateResource(workflowInstance.getState());
+    if (workflowInstance.getEndDate() != null){

Review comment:
       But the `getEndDate()` returns a `Date`, not a string. As I found out `!= null` is the correct way to check if a `Date` is null, isn't it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@oodt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org