You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2014/10/16 19:07:04 UTC
Re: Review Request 26809: Add a metric to count offers that do not
provide sufficent resources to launch a GC Executor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 10:07 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
wfarner's suggestion
Summary (updated)
-----------------
Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
Bugs: AURORA-843
https://issues.apache.org/jira/browse/AURORA-843
Repository: aurora
Description (updated)
-------
Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1
Diff: https://reviews.apache.org/r/26809/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Joe Smith
Re: Review Request 26809: Add a metric to count offers that do not
provide sufficent resources to launch a GC Executor
Posted by Kevin Sweeney <ke...@apache.org>.
> On Oct. 16, 2014, 10:45 a.m., Bill Farner wrote:
> > LGTM, i'm ambivalent to the stat name.
for consistency with the rest of the metrics exported by this file I prefer Zameer's suggestion
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/#review56951
-----------------------------------------------------------
On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26809/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 10:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-843
> https://issues.apache.org/jira/browse/AURORA-843
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1
>
> Diff: https://reviews.apache.org/r/26809/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26809: Add a metric to count offers that do not
provide sufficent resources to launch a GC Executor
Posted by Kevin Sweeney <ke...@apache.org>.
> On Oct. 16, 2014, 10:45 a.m., Bill Farner wrote:
> > LGTM, i'm ambivalent to the stat name.
>
> Kevin Sweeney wrote:
> for consistency with the rest of the metrics exported by this file I prefer Zameer's suggestion
actually it's already inconsistent, and Joe's patch follows the majority convention
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/#review56951
-----------------------------------------------------------
On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26809/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 10:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-843
> https://issues.apache.org/jira/browse/AURORA-843
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1
>
> Diff: https://reviews.apache.org/r/26809/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26809: Add a metric to count offers that do not
provide sufficent resources to launch a GC Executor
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/#review56951
-----------------------------------------------------------
Ship it!
LGTM, i'm ambivalent to the stat name.
- Bill Farner
On Oct. 16, 2014, 5:07 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26809/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 5:07 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-843
> https://issues.apache.org/jira/browse/AURORA-843
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1
>
> Diff: https://reviews.apache.org/r/26809/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26809: Add a metric to count offers that do not
provide sufficent resources to launch a GC Executor
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/#review56954
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26809/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 10:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-843
> https://issues.apache.org/jira/browse/AURORA-843
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1
>
> Diff: https://reviews.apache.org/r/26809/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26809: Add a metric to count offers that do not
provide sufficent resources to launch a GC Executor
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/#review56944
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java
<https://reviews.apache.org/r/26809/#comment97385>
shouldn't this just be 'gc_executor_insufficient_offers'?
- Zameer Manji
On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26809/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 10:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-843
> https://issues.apache.org/jira/browse/AURORA-843
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a metric to count offers that do not provide sufficent resources to launch a GC Executor
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1
>
> Diff: https://reviews.apache.org/r/26809/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Joe Smith
>
>