You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/03/28 14:21:42 UTC

Review Request 66331: Fixed test to assert precondition.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66331/
-----------------------------------------------------------

Review request for mesos and Jan Schlicht.


Repository: mesos


Description
-------

This patch changes an assert in
`ResourceProviderManagerHttpApiTest.UpdateOperationStatus` to make
sure a received message has the correct type. We later assume a
certain type which could and not aborting the test if an unexpected
message type is received would lead to hard runtime failures like
segmentation faults.


Diffs
-----

  src/tests/resource_provider_manager_tests.cpp d947bd037190e6b7ea7b2277b5fbe47816878de4 


Diff: https://reviews.apache.org/r/66331/diff/1/


Testing
-------


Thanks,

Benjamin Bannier

Re: Review Request 66331: Fixed test to assert precondition.

Posted by Jan Schlicht <ja...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66331/#review200110
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Schlicht


On March 28, 2018, 4:21 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66331/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 4:21 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes an assert in
> `ResourceProviderManagerHttpApiTest.UpdateOperationStatus` to make
> sure a received message has the correct type. We later assume a
> certain type which would not only abort the test if an unexpected
> message type is received but also lead to hard runtime failures like
> segmentation faults.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_provider_manager_tests.cpp d947bd037190e6b7ea7b2277b5fbe47816878de4 
> 
> 
> Diff: https://reviews.apache.org/r/66331/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>