[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3274: Let prelude import all expression functions

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3274:
URL: https://github.com/apache/arrow-datafusion/pull/3274#discussion_r956432300


##########
datafusion/core/src/prelude.rs:
##########
@@ -30,12 +30,6 @@ pub use crate::execution::context::{SessionConfig, SessionContext};
 pub use crate::execution::options::{
     AvroReadOptions, CsvReadOptions, NdJsonReadOptions, ParquetReadOptions,
 };
-pub use crate::logical_plan::{
-    approx_percentile_cont, array, ascii, avg, bit_length, btrim, cast, character_length,
-    chr, coalesce, col, concat, concat_ws, count, create_udf, date_part, date_trunc,
-    digest, exists, from_unixtime, in_list, in_subquery, initcap, left, length, lit,
-    lower, lpad, ltrim, max, md5, min, not_exists, not_in_subquery, now, octet_length,
-    random, regexp_match, regexp_replace, repeat, replace, reverse, right, rpad, rtrim,
-    scalar_subquery, sha224, sha256, sha384, sha512, split_part, starts_with, strpos,
-    substr, sum, to_hex, translate, trim, upper, Column, Expr, JoinType, Partitioning,
-};
+
+pub use crate::logical_plan::{Column, Expr, JoinType, Partitioning};

Review Comment:
   It would be nice to import `Expr`, `JoinType`, and `Partitioning` from `datafusion_expr` as well, and `Column` from `datafusion_common` to remove these remaining uses of the legacy `logical_plan` module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org