You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/05/07 14:28:44 UTC
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24281
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
IMPALA-14958: Fix missing lifecycle events for some nodes
Node Lifecycle Events in profile are incomplete for KuduScanNodeMt,
IcebergMetadataScanNode and SystemTableScanNode. It's fixed by adding
the invocation of ScopedOpenEventAdder and ScopedGetNextEventAdder in
the corresponding Open and GetNext implementations.
Also adds/adjusts the total time counter in some nodes.
Testing
- Added e2e tests
- Improved the timeline checking by verifying all the occurrences.
Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
---
M be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc
M be/src/exec/kudu/kudu-scan-node-mt.cc
M be/src/exec/system-table-scan-node.cc
M tests/custom_cluster/test_observability.py
M tests/query_test/test_observability.py
M tests/util/query_profile_util.py
6 files changed, 76 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/24281/1
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13430/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 22:02:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2: Code-Review+2
This looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 18:49:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
IMPALA-14958: Fix missing lifecycle events for some nodes
Node Lifecycle Events in profile are incomplete for KuduScanNodeMt,
IcebergMetadataScanNode and SystemTableScanNode. It's fixed by adding
the invocation of ScopedOpenEventAdder and ScopedGetNextEventAdder in
the corresponding Open and GetNext implementations.
Also adds/adjusts the total time counter in some nodes.
Testing
- Added e2e tests
- Improved the timeline checking by verifying all the occurrences.
Assisted-by: Composer 2
Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Reviewed-on: http://gerrit.cloudera.org:8080/24281
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc
M be/src/exec/kudu/kudu-scan-node-mt.cc
M be/src/exec/system-table-scan-node.cc
M tests/custom_cluster/test_observability.py
M tests/query_test/test_observability.py
M tests/util/query_profile_util.py
6 files changed, 76 insertions(+), 39 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13431/
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 06:58:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 18:34:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22352/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 14:50:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
IMPALA-14958: Fix missing lifecycle events for some nodes
Node Lifecycle Events in profile are incomplete for KuduScanNodeMt,
IcebergMetadataScanNode and SystemTableScanNode. It's fixed by adding
the invocation of ScopedOpenEventAdder and ScopedGetNextEventAdder in
the corresponding Open and GetNext implementations.
Also adds/adjusts the total time counter in some nodes.
Testing
- Added e2e tests
- Improved the timeline checking by verifying all the occurrences.
Assisted-by: Composer 2
Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
---
M be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.cc
M be/src/exec/kudu/kudu-scan-node-mt.cc
M be/src/exec/system-table-scan-node.cc
M tests/custom_cluster/test_observability.py
M tests/query_test/test_observability.py
M tests/util/query_profile_util.py
6 files changed, 76 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/24281/2
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13430/
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 02:25:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13431/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 02:40:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2:
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13430/
The failure is unrelated: https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/8825/testReport/junit/org.apache.impala.planner/PlannerTest/___/
It's tracked in IMPALA-7523.
Rerun the job.
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 02:39:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14958: Fix missing lifecycle events for some nodes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24281 )
Change subject: IMPALA-14958: Fix missing lifecycle events for some nodes
......................................................................
Patch Set 2: Verified+1
> Patch Set 2:
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13431/
The failure is due to a network issue in the build:
https://jenkins.impala.io/job/all-build-options-ub2004/4213/console
03:42:16 [ERROR] Failed to execute goal on project impala-frontend: Could not collect dependencies for project org.apache.impala:impala-frontend:jar:4.0.0-20260508
03:42:16 [ERROR] Failed to read artifact descriptor for net.shibboleth.tool:xmlsectool:jar:2.0.0
03:42:16 [ERROR] Caused by: The following artifacts could not be resolved: net.shibboleth.tool:xmlsectool:pom:2.0.0 (absent): Could not transfer artifact net.shibboleth.tool:xmlsectool:pom:2.0.0 from/to impala.cdp.repo (https://native-toolchain-us-west-2.s3.us-west-2.amazonaws.com/build/cdp_components/73534044/maven): status code: 403, reason phrase: Forbidden (403)
Since the previous GVO already verified this job: https://jenkins.impala.io/job/all-build-options-ub2004/4212/
, manually marking +1 for Verified.
--
To view, visit http://gerrit.cloudera.org:8080/24281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39abc3a74df7b4ea3383f104fe1a74ff09f18324
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 07:28:04 +0000
Gerrit-HasComments: No