[GitHub] [lucene-solr] atris commented on pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

[GitBox <gi...@apache.org>]

atris commented on pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671879842


   > The configuration can be as simple as
   > 
   > `<circuitBreaker memoryCircuitBreakerThresholdPct="" isCpuCircuitBreakerEnabled="true" memoryCircuitBreakerThresholdPct ="" cpuCircuitBreakerThresholdPct="">`
   > 
   > This way you can just read all the attributes all at once from the `PluginInfo` .
   > CircuitBreaker should be a type of plugin. It should be an interface
   
   As discussed offline, I will refactor circuit breaker infrastructure to use PluginInfo as a part of 8.7 (hence will leave this PR's JIRA open for that effort). No proceeding with that effort in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org