You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Kelley Reynolds (Created) (JIRA)" <ji...@apache.org> on 2011/10/28 21:45:32 UTC

[jira] [Created] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Counter decrements require a space around the minus sign but not around the plus sign
-------------------------------------------------------------------------------------

                 Key: CASSANDRA-3418
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.0.0
            Reporter: Kelley Reynolds
            Priority: Minor


UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-3418:
---------------------------------------

    Attachment: CASSANDRA-3418.patch
    
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3418.patch
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-3418:
---------------------------------------

    Attachment: CASSANDRA-3418-fix.patch

here is the patch that fixes problem that Paul found. 

@Jonathan: I agree, we probably should do the same thing for CQL as we did for CLI.
                
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3418-fix.patch, CASSANDRA-3418.patch
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149867#comment-13149867 ] 

paul cannon commented on CASSANDRA-3418:
----------------------------------------

This doesn't do the right thing when minusing a negative value, like:

{noformat}
UPDATE validation_cf_counter SET test = test - -1 WHERE id='test_key';
{noformat}

It subtracts 1, instead of adding 1.
                
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3418.patch
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3418:
--------------------------------------

    Fix Version/s: 1.0.2
         Assignee: Pavel Yaskevich
    
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.2
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "Pavel Yaskevich (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151417#comment-13151417 ] 

Pavel Yaskevich commented on CASSANDRA-3418:
--------------------------------------------

Committed.
                
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3418-fix.patch, CASSANDRA-3418.patch
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149880#comment-13149880 ] 

Jonathan Ellis commented on CASSANDRA-3418:
-------------------------------------------

bq. It's not related to QueryProcessor tho

But that's the simplest way to add CQL tests I would think?  Open to other ideas.
                
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3418.patch
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151383#comment-13151383 ] 

paul cannon commented on CASSANDRA-3418:
----------------------------------------

+1 for the fix
                
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3418-fix.patch, CASSANDRA-3418.patch
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3418) Counter decrements require a space around the minus sign but not around the plus sign

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148556#comment-13148556 ] 

Jonathan Ellis commented on CASSANDRA-3418:
-------------------------------------------

+1

time to add QueryProcessorTest?
                
> Counter decrements require a space around the minus sign but not around the plus sign
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3418
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3418
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Kelley Reynolds
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3418.patch
>
>
> UPDATE validation_cf_counter SET test=test+1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test + 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test - 1 WHERE id='test_key' => Success
> UPDATE validation_cf_counter SET test=test-1 WHERE id='test_key' => Failure (line 1:38 no viable alternative at input 'test')

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira