hadoopkandy opened a new pull request, #5821: URL: https://github.com/apache/kyuubi/pull/5821 # :mag: Description ## Issue References ๐ <!-- Append the issue number after #. If there is no issue for you to link create one or --> <!-- If there are no issues to link, please provide details here. --> This pull request fixes # ## Describe Your Solution ๐ง Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes :bookmark: <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan ๐งช #### Behavior Without This Pull Request :coffin: #### Behavior With This Pull Request :tada: #### Related Unit Tests --- # Checklists ## ๐ Author Self Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [ ] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## ๐ Committer Pre-Merge Checklist - [ ] Pull request title is okay. - [ ] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For additional commands, e-mail: notifications-help@kyuubi.apache.org
hadoopkandy commented on code in PR #5821:
URL: https://github.com/apache/kyuubi/pull/5821#discussion_r1418244862
##########
docs/configuration/settings.md:
##########
@@ -142,6 +142,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.engine.flink.extra.classpath | <undefined> | The extra classpath for the Flink SQL engine, for configuring the location of hadoop client jars, etc. Only effective in yarn session mode.
| string | 1.6.0 |
| kyuubi.engine.flink.java.options | <undefined> | The extra Java options for the Flink SQL engine. Only effective in yarn session mode.
| string | 1.6.0 |
| kyuubi.engine.flink.memory | 1g | The heap memory for the Flink SQL engine. Only effective in yarn session mode.
| string | 1.6.0 |
+| kyuubi.engine.flink.initialize.sql | | the initialize sql for flink engine. it fallback to `kyuubi.engine.initialize.sql`.
| seq | 1.8.1 |
Review Comment:
Thanks, After adopting your suggestion, it passed the related CI test, otherwise it won't be able to pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
hadoopkandy commented on PR #5821: URL: https://github.com/apache/kyuubi/pull/5821#issuecomment-1844144824 > @hadoopkandy Thanks, I left some minor comments, please take a look. Thanks, I committed it again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For additional commands, e-mail: notifications-help@kyuubi.apache.org
wForget commented on code in PR #5821:
URL: https://github.com/apache/kyuubi/pull/5821#discussion_r1417120449
##########
docs/configuration/settings.md:
##########
@@ -142,6 +142,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.engine.flink.extra.classpath | <undefined> | The extra classpath for the Flink SQL engine, for configuring the location of hadoop client jars, etc. Only effective in yarn session mode.
| string | 1.6.0 |
| kyuubi.engine.flink.java.options | <undefined> | The extra Java options for the Flink SQL engine. Only effective in yarn session mode.
| string | 1.6.0 |
| kyuubi.engine.flink.memory | 1g | The heap memory for the Flink SQL engine. Only effective in yarn session mode.
| string | 1.6.0 |
+| kyuubi.engine.flink.initialize.sql | | the initialize sql for flink engine. it fallback to `kyuubi.engine.initialize.sql`.
| seq | 1.8.1 |
Review Comment:
The setting file is regenerated using the script, we should change the description of conf.
FYI: https://kyuubi.readthedocs.io/en/master/contributing/code/developer.html#append-descriptions-of-new-configurations-to-settings-md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
pan3793 commented on code in PR #5821:
URL: https://github.com/apache/kyuubi/pull/5821#discussion_r1417041449
##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java:
##########
@@ -85,7 +85,7 @@ public KyuubiBeeLine(boolean isBeeLine) {
@Override
void usage() {
super.usage();
- output("Usage: java \" + KyuubiBeeLine.class.getCanonicalName()");
+ output("Usage: java " + KyuubiBeeLine.class.getCanonicalName());
Review Comment:
this is an independent issue, you can fix a in an independent PR first :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
pan3793 commented on PR #5821: URL: https://github.com/apache/kyuubi/pull/5821#issuecomment-1844168505 Thanks, merged to master/1.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For additional commands, e-mail: notifications-help@kyuubi.apache.org
hadoopkandy commented on code in PR #5821:
URL: https://github.com/apache/kyuubi/pull/5821#discussion_r1417079137
##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java:
##########
@@ -85,7 +85,7 @@ public KyuubiBeeLine(boolean isBeeLine) {
@Override
void usage() {
super.usage();
- output("Usage: java \" + KyuubiBeeLine.class.getCanonicalName()");
+ output("Usage: java " + KyuubiBeeLine.class.getCanonicalName());
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
pan3793 closed pull request #5821: [KYUUBI #5756] Introduce specified initialized SQL to every engine URL: https://github.com/apache/kyuubi/pull/5821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For additional commands, e-mail: notifications-help@kyuubi.apache.org
pan3793 commented on PR #5821: URL: https://github.com/apache/kyuubi/pull/5821#issuecomment-1842568891 cc @YesOrNo828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org For additional commands, e-mail: notifications-help@kyuubi.apache.org
YesOrNo828 commented on code in PR #5821:
URL: https://github.com/apache/kyuubi/pull/5821#discussion_r1417090260
##########
docs/configuration/settings.md:
##########
@@ -177,6 +178,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.engine.spark.python.env.archive | <undefined> | Portable Python env archive used for Spark engine Python language mode.
| string | 1.7.0 |
| kyuubi.engine.spark.python.env.archive.exec.path | bin/python | The Python exec path under the Python env archive.
| string | 1.7.0 |
| kyuubi.engine.spark.python.home.archive | <undefined> | Spark archive containing $SPARK_HOME/python directory, which is used to init session Python worker for Python language mode.
| string | 1.7.0 |
+| kyuubi.engine.spark.initialize.sql | | the initialize sql for spark engine. it it fallback to `kyuubi.engine.session.initialize.sql`
| seq | 1.8.1 |
Review Comment:
```suggestion
| kyuubi.engine.spark.initialize.sql | | The initialize sql for spark engine. It fallback to `kyuubi.engine.initialize.sql`
| seq | 1.8.1 |
```
##########
docs/configuration/settings.md:
##########
@@ -142,6 +142,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.engine.flink.extra.classpath | <undefined> | The extra classpath for the Flink SQL engine, for configuring the location of hadoop client jars, etc. Only effective in yarn session mode.
| string | 1.6.0 |
| kyuubi.engine.flink.java.options | <undefined> | The extra Java options for the Flink SQL engine. Only effective in yarn session mode.
| string | 1.6.0 |
| kyuubi.engine.flink.memory | 1g | The heap memory for the Flink SQL engine. Only effective in yarn session mode.
| string | 1.6.0 |
+| kyuubi.engine.flink.initialize.sql | | the initialize sql for flink engine. it fallback to `kyuubi.engine.initialize.sql`.
| seq | 1.8.1 |
Review Comment:
```suggestion
| kyuubi.engine.flink.initialize.sql | | The initialize sql for flink engine. It fallback to `kyuubi.engine.initialize.sql`.
| seq | 1.8.1 |
```
##########
docs/configuration/settings.md:
##########
@@ -429,6 +431,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.session.engine.flink.fetch.timeout | <undefined> | Result fetch timeout for Flink engine. If the timeout is reached, the result fetch would be stopped and the current fetched would be returned. If no data are fetched, a TimeoutException would be thrown. | duration | 1.8.0 |
| kyuubi.session.engine.flink.main.resource | <undefined> | The package used to create Flink SQL engine remote job. If it is undefined, Kyuubi will use the default | string | 1.4.0 |
| kyuubi.session.engine.flink.max.rows | 1000000 | Max rows of Flink query results. For batch queries, rows exceeding the limit would be ignored. For streaming queries, the query would be canceled if the limit is reached. | int | 1.5.0 |
+| kyuubi.session.engine.flink.initialize.sql | | the initialize sql for flink session.it fallback to `kyuubi.engine.session.initialize.sql`. | seq | 1.8.1 |
Review Comment:
```suggestion
| kyuubi.session.engine.flink.initialize.sql | | The initialize sql for Flink session. It fallback to `kyuubi.engine.session.initialize.sql`. | seq | 1.8.1 |
```
##########
docs/configuration/settings.md:
##########
@@ -444,6 +447,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.session.engine.spark.progress.timeFormat | yyyy-MM-dd HH:mm:ss.SSS | The time format of the progress bar | string | 1.6.0 |
| kyuubi.session.engine.spark.progress.update.interval | PT1S | Update period of progress bar. | duration | 1.6.0 |
| kyuubi.session.engine.spark.showProgress | false | When true, show the progress bar in the Spark's engine log. | boolean | 1.6.0 |
+| kyuubi.session.engine.spark.initialize.sql | | the initialize sql for spark session. it fallback to `kyuubi.engine.session.initialize.sql` | seq | 1.8.1 |
Review Comment:
```suggestion
| kyuubi.session.engine.spark.initialize.sql | | The initialize sql for spark session. It fallback to `kyuubi.engine.session.initialize.sql`. | seq | 1.8.1 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org