You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 21:33:16 UTC
[GitHub] [arrow] alamb opened a new pull request #8931: ARROW-10933: [Rust] Update readme files in regard to nightly rust
alamb opened a new pull request #8931:
URL: https://github.com/apache/arrow/pull/8931
Update the docs with respect to changes after https://github.com/apache/arrow/pull/8698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #8931: ARROW-10933: [Rust] Update readme files in regard to nightly rust
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #8931:
URL: https://github.com/apache/arrow/pull/8931#discussion_r544369896
##########
File path: rust/README.md
##########
@@ -111,10 +111,8 @@ from here on, this is a pure Rust project and `cargo` can be used to run tests,
## Code Formatting
-Our CI uses `rustfmt` to check code formatting. Although the project is
-built and tested against nightly rust we use the stable version of
-`rustfmt`. So before submitting a PR be sure to run the following
-and check for lint issues:
+Our CI uses `rustfmt` to check code formatting. Before submitting a
+PR be sure to run the following and check for lint issues:
```bash
cargo +stable fmt --all -- --check
Review comment:
nm, I suppose people using simd will still be using nightly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8931: ARROW-10933: [Rust] Update readme files in regard to nightly rust
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8931:
URL: https://github.com/apache/arrow/pull/8931#issuecomment-745586315
https://issues.apache.org/jira/browse/ARROW-10933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #8931: ARROW-10933: [Rust] Update readme files in regard to nightly rust
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8931:
URL: https://github.com/apache/arrow/pull/8931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #8931: ARROW-10933: [Rust] Update readme files in regard to nightly rust
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #8931:
URL: https://github.com/apache/arrow/pull/8931#discussion_r544369209
##########
File path: rust/README.md
##########
@@ -111,10 +111,8 @@ from here on, this is a pure Rust project and `cargo` can be used to run tests,
## Code Formatting
-Our CI uses `rustfmt` to check code formatting. Although the project is
-built and tested against nightly rust we use the stable version of
-`rustfmt`. So before submitting a PR be sure to run the following
-and check for lint issues:
+Our CI uses `rustfmt` to check code formatting. Before submitting a
+PR be sure to run the following and check for lint issues:
```bash
cargo +stable fmt --all -- --check
Review comment:
do we still need the `+stable` flag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org