You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/26 13:21:37 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #8534: fix: aws hook should work without conn id

turbaszek commented on a change in pull request #8534:
URL: https://github.com/apache/airflow/pull/8534#discussion_r415309631



##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -62,16 +63,14 @@ class AwsBaseHook(BaseHook):
 
     def __init__(
             self,
-            aws_conn_id="aws_default",
+            aws_conn_id: Optional[str] = "aws_default",

Review comment:
       @zhongjiajie is right:
   > Optional[X] is equivalent to Union[X, None].
   
   we should use `aws_conn_id: str = "aws_default"` because passing `None` will cause an error (probably) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org