You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/28 01:23:25 UTC
[GitHub] [airflow] kaxil opened a new pull request #17875: BugFix: ``TimeSensorAsync`` returns a naive datetime
kaxil opened a new pull request #17875:
URL: https://github.com/apache/airflow/pull/17875
My fix in https://github.com/apache/airflow/pull/17748 was only partially correct and I missed one part. `TimeSensorAsync` passed a naive datetime which failed when passed to `DateTimeTrigger`. This PR fixes it and adds test to avoid regression.
Error:
```
[2021-08-27 23:31:11,508] {taskinstance.py:1657} ERROR - Task failed with exception
Traceback (most recent call last):
File "/opt/airflow/airflow/models/taskinstance.py", line 1296, in _run_raw_task
self._prepare_and_execute_task_with_callbacks(context, task)
File "/opt/airflow/airflow/models/taskinstance.py", line 1415, in _prepare_and_execute_task_with_callbacks
result = self._execute_task(context, task_copy)
File "/opt/airflow/airflow/models/taskinstance.py", line 1471, in _execute_task
result = execute_callable(context=context)
File "/opt/airflow/airflow/sensors/time_sensor.py", line 60, in execute
trigger=DateTimeTrigger(moment=self.target_datetime),
File "/opt/airflow/airflow/triggers/temporal.py", line 40, in __init__
raise ValueError("You cannot pass naive datetimes")
ValueError: You cannot pass naive datetimes
```
Example DAG:
```python
from datetime import timedelta, time
from airflow import DAG
from airflow.sensors.time_sensor import TimeSensorAsync
from airflow.utils import dates, timezone
with DAG(
dag_id='example_date_time_async_operator',
schedule_interval='0 0 * * *',
start_date=dates.days_ago(2),
dagrun_timeout=timedelta(minutes=60),
tags=['example', 'example2', 'async'],
) as dag:
TimeSensorAsync(task_id="test-2", target_time=time(0, 38, 0))
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17875: BugFix: ``TimeSensorAsync`` returns a naive datetime
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17875:
URL: https://github.com/apache/airflow/pull/17875#issuecomment-908470632
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17875: BugFix: ``TimeSensorAsync`` returns a naive datetime
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17875:
URL: https://github.com/apache/airflow/pull/17875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17875: BugFix: ``TimeSensorAsync`` returns a naive datetime
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17875:
URL: https://github.com/apache/airflow/pull/17875#issuecomment-908470632
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17875: BugFix: ``TimeSensorAsync`` returns a naive datetime
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17875:
URL: https://github.com/apache/airflow/pull/17875#issuecomment-907545148
cc @andrewgodwin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17875: BugFix: ``TimeSensorAsync`` returns a naive datetime
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17875:
URL: https://github.com/apache/airflow/pull/17875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org