You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/26 09:07:11 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request, #9463: Refactor DataTable implementations to pinot-common
xiangfu0 opened a new pull request, #9463:
URL: https://github.com/apache/pinot/pull/9463
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #9463: Refactor DataTable implementations to pinot-common
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9463:
URL: https://github.com/apache/pinot/pull/9463#issuecomment-1257803792
# [Codecov](https://codecov.io/gh/apache/pinot/pull/9463?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9463](https://codecov.io/gh/apache/pinot/pull/9463?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36e10de) into [master](https://codecov.io/gh/apache/pinot/commit/e2d8aaab7236aa8dccf6b5cfaefd3d98ea0e4639?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2d8aaa) will **decrease** coverage by `41.55%`.
> The diff coverage is `43.55%`.
> :exclamation: Current head 36e10de differs from pull request most recent head 9446a96. Consider uploading reports for the commit 9446a96 to get more accurate results
```diff
@@ Coverage Diff @@
## master #9463 +/- ##
=============================================
- Coverage 69.83% 28.28% -41.56%
+ Complexity 5127 53 -5074
=============================================
Files 1909 1898 -11
Lines 101749 101401 -348
Branches 15440 15402 -38
=============================================
- Hits 71059 28681 -42378
- Misses 25674 69926 +44252
+ Partials 5016 2794 -2222
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `25.98% <36.80%> (+0.02%)` | :arrow_up: |
| integration2 | `24.87% <41.71%> (+0.16%)` | :arrow_up: |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/pinot/common/data/ObjectSerDeUtils.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9PYmplY3RTZXJEZVV0aWxzLmphdmE=) | `46.03% <ø> (ø)` | |
| [...apache/pinot/common/data/customobject/AvgPair.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvQXZnUGFpci5qYXZh) | `58.06% <ø> (ø)` | |
| [...inot/common/data/customobject/CovarianceTuple.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvQ292YXJpYW5jZVR1cGxlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...not/common/data/customobject/CustomSerDeUtils.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvQ3VzdG9tU2VyRGVVdGlscy5qYXZh) | `37.09% <ø> (ø)` | |
| [...pinot/common/data/customobject/DoubleLongPair.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvRG91YmxlTG9uZ1BhaXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../pinot/common/data/customobject/FloatLongPair.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvRmxvYXRMb25nUGFpci5qYXZh) | `0.00% <ø> (ø)` | |
| [...he/pinot/common/data/customobject/IntLongPair.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvSW50TG9uZ1BhaXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...e/pinot/common/data/customobject/LongLongPair.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvTG9uZ0xvbmdQYWlyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...inot/common/data/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvTWluTWF4UmFuZ2VQYWlyLmphdmE=) | `75.86% <ø> (ø)` | |
| [...pinot/common/data/customobject/QuantileDigest.java](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9jdXN0b21vYmplY3QvUXVhbnRpbGVEaWdlc3QuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [1499 more](https://codecov.io/gh/apache/pinot/pull/9463/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 closed pull request #9463: Refactor DataTable implementations to pinot-common
Posted by GitBox <gi...@apache.org>.
xiangfu0 closed pull request #9463: Refactor DataTable implementations to pinot-common
URL: https://github.com/apache/pinot/pull/9463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org