[jira] [Comment Edited] (OOZIE-2748) NPE in LauncherMapper.printArgs()

["Peter Bacsko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724992#comment-15724992 ] 

Peter Bacsko edited comment on OOZIE-2748 at 12/6/16 10:00 AM:
---------------------------------------------------------------

Honestly I misunderstood this thing a little bit - I thought there are only a single {{<arg>}} element in the XML, not a list of {{<arg>}}. So I was a bit confused :)

Anyway if that's the case, I do agree with the decision that we should drop nulls. I think programs usually scan through the {{args[]}} and 99% of them are unprepared to handle nulls. I will update the patch soon.


was (Author: pbacsko):
Honestly I misunderstood this thing a little bit - I thought there are only a single {{<arg>}} element in the XML, not a list of {{<arg>}}. So I was a bit confused :)

Anyway if that's the case, I do agree with the decision that we should drop nulls. I think programs usually scan through the {{args[]}} and 99% of them are unprepared to handle nulls.

> NPE in LauncherMapper.printArgs()
> ---------------------------------
>
>                 Key: OOZIE-2748
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2748
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.2.0
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>         Attachments: OOZIE-2748-001.patch, OOZIE-2748-002.patch
>
>
> If we define argument for the Spark action like this
> {code}
>         <spark xmlns="uri:oozie:spark-action:0.2">
>             <job-tracker>${jobTracker}</job-tracker>
>             <name-node>${nameNode}</name-node>
>             <configuration>
>                 <property>
>                     <name>oozie.use.system.libpath</name>
>                     <value>true</value>
>                 </property>
>                 <property>
>                     <name></name>
>                     <value></value>
>                 </property>
>             </configuration>
>             <master>yarn-cluster</master>
>             <mode>cluster</mode>
>             <name>Something</name>
>             <class>package.of.my.Class</class>
>             <jar>${nameNode}/myjar.jar</jar>
>             <arg></arg>    <---  cause of the NPE
>         </spark>
> {code}
> then we get a NullPointerException in LauncherMapper:
> {code}
> Failing Oozie Launcher, Main class [org.apache.oozie.action.hadoop.SparkMain], exception invoking main(), null
> java.lang.NullPointerException
> 	at org.apache.oozie.action.hadoop.LauncherMapper.printArgs(LauncherMapper.java:627)
> 	at org.apache.oozie.action.hadoop.LauncherMapper.map(LauncherMapper.java:212)
> 	at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54)
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)