You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/07 21:38:48 UTC
[GitHub] [nifi] turcsanyip commented on a change in pull request #3944:
NIFI-6939: Upgrade Atlas client dependency to 2.0.0
turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363963580
##########
File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/hook/NotificationSender.java
##########
@@ -290,17 +293,17 @@ void send(final List<HookNotification.HookNotificationMessage> messages, final C
// org.json4s.package$MappingException: Can't find ScalaSig for class org.apache.atlas.typesystem.Referenceable
flowPathRef.set(ATTR_INPUTS, new ArrayList<>(distinctInputs.values()));
flowPathRef.set(ATTR_OUTPUTS, new ArrayList<>(distinctOutputs.values()));
- return new HookNotification.EntityPartialUpdateRequest(NIFI_USER, TYPE_NIFI_FLOW_PATH,
+ return new HookNotificationV1.EntityPartialUpdateRequest(NIFI_USER, TYPE_NIFI_FLOW_PATH,
ATTR_QUALIFIED_NAME, flowPathQualifiedName, flowPathRef);
})
.filter(Objects::nonNull)
.collect(Collectors.toList());
metrics.uniquePartialNiFiFlowPathUpdates = deduplicatedMessages.size();
- notifier.accept(deduplicatedMessages);
+ notifier.accept(deduplicatedMessages, null);
Review comment:
Good point. I retested the reporting task with kerberized Atlas servers (version 1.x and 2.0) and it worked fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services