You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Axel Delahaye <ax...@worldline.com> on 2014/05/19 11:53:42 UTC
Review Request 21624: Mouseover to click for quickview
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21624/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
To avoid undesired opening of the quickview or mistake.
Ex: destroy an instance and it was the top instance quickview which was open.
For the quickview '+' button, I change the mouseover to the click handler.
Diffs
-----
ui/scripts/ui/widgets/listView.js d5ba2fe
Diff: https://reviews.apache.org/r/21624/diff/
Testing
-------
Thanks,
Axel Delahaye
Re: Review Request 21624: Mouseover to click for quickview
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21624/#review78986
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Dec. 19, 2014, 1:05 a.m., Axel Delahaye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21624/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 1:05 a.m.)
>
>
> Review request for cloudstack and Pierre-Luc Dion.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> To avoid undesired opening of the quickview or mistake.
> Ex: destroy an instance and it was the top instance quickview which was open.
>
> For the quickview '+' button, I change the mouseover to the click handler.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/listView.js d5ba2fe
>
> Diff: https://reviews.apache.org/r/21624/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Axel Delahaye
>
>
Re: Review Request 21624: Mouseover to click for quickview
Posted by Axel Delahaye <ax...@worldline.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21624/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 1:05 a.m.)
Review request for cloudstack and Pierre-Luc Dion.
Repository: cloudstack-git
Description
-------
To avoid undesired opening of the quickview or mistake.
Ex: destroy an instance and it was the top instance quickview which was open.
For the quickview '+' button, I change the mouseover to the click handler.
Diffs
-----
ui/scripts/ui/widgets/listView.js d5ba2fe
Diff: https://reviews.apache.org/r/21624/diff/
Testing
-------
Thanks,
Axel Delahaye
RE: Review Request 21624: Mouseover to click for quickview
Posted by Stephen Turner <St...@citrix.com>.
You didn't assign any reviewers, but I suggest Brian Federle would be the best person, so cc:ing him.
--
Stephen Turner
-----Original Message-----
From: Axel Delahaye [mailto:noreply@reviews.apache.org] On Behalf Of Axel Delahaye
Sent: 19 May 2014 10:54
To: Axel Delahaye; cloudstack
Subject: Review Request 21624: Mouseover to click for quickview
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21624/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
To avoid undesired opening of the quickview or mistake.
Ex: destroy an instance and it was the top instance quickview which was open.
For the quickview '+' button, I change the mouseover to the click handler.
Diffs
-----
ui/scripts/ui/widgets/listView.js d5ba2fe
Diff: https://reviews.apache.org/r/21624/diff/
Testing
-------
Thanks,
Axel Delahaye