You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/18 16:47:15 UTC

[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #355: [YUNIKORN-1009] Add git sha as label to admission controller image

craigcondit commented on pull request #355:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/355#issuecomment-1015603872


   > hi @craigcondit can we reuse the SHA variables in the makefile to avoid dup code ? thanks
   
   I tried this, but I feel it actually makes it much less readable. I'd prefer to keep it as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org