You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/17 18:03:08 UTC
[GitHub] [apisix-ingress-controller] shreemaan-abhishek opened a new pull request, #1538: feat: sync plugin-config labels to apisix
shreemaan-abhishek opened a new pull request, #1538:
URL: https://github.com/apache/apisix-ingress-controller/pull/1538
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
New feature provided
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Closes #775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel merged pull request #1538: feat: sync plugin-config labels to apisix
Posted by "lingsamuel (via GitHub)" <gi...@apache.org>.
lingsamuel merged PR #1538:
URL: https://github.com/apache/apisix-ingress-controller/pull/1538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1538: feat: sync plugin-config labels to apisix
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1538:
URL: https://github.com/apache/apisix-ingress-controller/pull/1538#issuecomment-1367778479
Please resolve conflicts, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] shreemaan-abhishek commented on pull request #1538: feat: sync plugin-config labels to apisix
Posted by GitBox <gi...@apache.org>.
shreemaan-abhishek commented on PR #1538:
URL: https://github.com/apache/apisix-ingress-controller/pull/1538#issuecomment-1367812086
@tao12345666333 conflicts are now resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1538: feat: sync plugin-config labels to apisix
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1538:
URL: https://github.com/apache/apisix-ingress-controller/pull/1538#issuecomment-1356822725
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1538](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f3392f0) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/d22a6fc820f7699af411b8ecaa971307cfc82dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d22a6fc) will **increase** coverage by `0.29%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
+ Coverage 41.22% 41.51% +0.29%
==========================================
Files 85 87 +2
Lines 7440 7414 -26
==========================================
+ Hits 3067 3078 +11
+ Misses 4020 3985 -35
+ Partials 353 351 -2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roviders/apisix/translation/apisix\_pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3BsdWdpbmNvbmZpZy5nbw==) | `29.72% <0.00%> (-0.83%)` | :arrow_down: |
| [pkg/providers/ingress/provider.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3Byb3ZpZGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/providers/k8s/pod/provider.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9rOHMvcG9kL3Byb3ZpZGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/providers/utils/scheme.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy91dGlscy9zY2hlbWUuZ28=) | `100.00% <0.00%> (ø)` | |
| [pkg/providers/utils/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy91dGlscy9zY2hlbWEuZ28=) | `100.00% <0.00%> (ø)` | |
| [pkg/providers/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL2luZ3Jlc3MuZ28=) | `4.09% <0.00%> (+0.10%)` | :arrow_up: |
| [...kg/providers/apisix/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `62.33% <0.00%> (+6.49%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org