[GitHub] [activemq] gemmellr commented on a diff in pull request #835: [AMQ-8593] Use inclusive terminology for network connector transports

[GitBox <gi...@apache.org>]

gemmellr commented on code in PR #835:
URL: https://github.com/apache/activemq/pull/835#discussion_r863632302


##########
activemq-client/src/main/java/org/apache/activemq/transport/discovery/masterslave/MasterSlaveDiscoveryAgentFactory.java:
##########
@@ -27,6 +27,7 @@
 import java.net.URI;
 import java.util.Map;
 
+@Deprecated

Review Comment:
   Ditto



##########
activemq-client/src/main/java/org/apache/activemq/transport/discovery/masterslave/MasterSlaveDiscoveryAgent.java:
##########
@@ -24,7 +24,10 @@
 /**
  * A static DiscoveryAgent that supports connecting to a Master / Slave tuple
  * of brokers.
+ *
+ * @deprecated This class is superseded by HADiscoveryAgent and will be removed in 5.18.0.
  */
+@Deprecated

Review Comment:
   Can it use the 'for removal' flag? If so it seems like it should. Though i realise most things arent going to touch the code itself so it would really only be for descriptive purposes.
   
   (I've yet to use it myself so not clear when it came in) 



##########
activemq-unit-tests/src/test/java/org/apache/activemq/network/NetworkConnectionsTest.java:
##########
@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>

Review Comment:
   Seems like this should be unwound...but if a change actually needs made, I'd make the licence header a comment rather than Javadoc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org