You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/22 02:30:02 UTC

[GitHub] [spark] GuoPhilipse opened a new pull request #28605: add docs for sql migration-guide

GuoPhilipse opened a new pull request #28605:
URL: https://github.com/apache/spark/pull/28605


   
   
   ### What changes were proposed in this pull request?
   add docs for sql migration-guide
   
   ### Why are the changes needed?
   let user know more about the scenarios in which Hive and Spark generate different results
   
   
   ### Does this PR introduce _any_ user-facing change?
   no
   
   
   ### How was this patch tested?
   no need to test
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon edited a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632678653


   Merged to master and branch-3.0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632663870


   **[Test build #122998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122998/testReport)** for PR 28605 at commit [`5333afd`](https://github.com/apache/spark/commit/5333afd65a702aa4e856f7fd1bc1338f95859f83).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GuoPhilipse commented on a change in pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on a change in pull request #28605:
URL: https://github.com/apache/spark/pull/28605#discussion_r429205396



##########
File path: docs/sql-migration-guide.md
##########
@@ -961,3 +961,4 @@ Below are the scenarios in which Hive and Spark generate different results:
 * `SQRT(n)` If n < 0, Hive returns null, Spark SQL returns NaN.
 * `ACOS(n)` If n < -1 or n > 1, Hive returns null, Spark SQL returns NaN.
 * `ASIN(n)` If n < -1 or n > 1, Hive returns null, Spark SQL returns NaN.
+* `CAST(n as timestamp)` If n is Byte/Short/Int/Long data type, Hive treat n as milliseconds unit , while Spark SQL as seconds unit.

Review comment:
       cool , have improved it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632658740






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632658189


   **[Test build #122998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122998/testReport)** for PR 28605 at commit [`5333afd`](https://github.com/apache/spark/commit/5333afd65a702aa4e856f7fd1bc1338f95859f83).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632636610


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GuoPhilipse commented on pull request #28605: add docs for sql migration-guide

Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632447975


   fine, i will create a JIRA for it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632644750






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632658740






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GuoPhilipse commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632620562


   @HyukjinKwon  what else did i need to do to close the jira and merge the patch ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632663999






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632639429


   **[Test build #122995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122995/testReport)** for PR 28605 at commit [`2f5b388`](https://github.com/apache/spark/commit/2f5b3880ab297f1ec65b22625346b27a7cb74b83).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28605:
URL: https://github.com/apache/spark/pull/28605#discussion_r429186020



##########
File path: docs/sql-migration-guide.md
##########
@@ -961,3 +961,4 @@ Below are the scenarios in which Hive and Spark generate different results:
 * `SQRT(n)` If n < 0, Hive returns null, Spark SQL returns NaN.
 * `ACOS(n)` If n < -1 or n > 1, Hive returns null, Spark SQL returns NaN.
 * `ASIN(n)` If n < -1 or n > 1, Hive returns null, Spark SQL returns NaN.
+* `CAST(n as timestamp)` If n is Byte/Short/Int/Long data type, Hive treat n as milliseconds unit , while Spark SQL as seconds unit.

Review comment:
       Let's rephrase a bit more:
   
   `CAST(n AS TIMESTAMP)` If n is integral numbers, Hive treats n as milliseconds, Spark SQL treats n as seconds .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632663999






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632658189


   **[Test build #122998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122998/testReport)** for PR 28605 at commit [`5333afd`](https://github.com/apache/spark/commit/5333afd65a702aa4e856f7fd1bc1338f95859f83).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GuoPhilipse commented on pull request #28605: [SPARK-31790][DOCS] Document cast(ts as long) difference between Hive and Spark

Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632455796


   @HyukjinKwon   cast(ts as long) may change to  cast(long as timestamp) ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28605: [SPARK-31790][DOCS] Document cast(ts as long) difference between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632444721


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632639926






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #28605: add docs for sql migration-guide

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632443991


   @GuoPhilipse, let's file a JIRA although it's doc only, it's user-facing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632678653


   Merged to master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28605:
URL: https://github.com/apache/spark/pull/28605


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632644750






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632639926






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632445014


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #28605: [SPARK-31790][DOCS] Document cast(ts as long) difference between Hive and Spark

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632467539


   @GuoPhilipse, feel free to fix the PR title and PR description with examples. It's your PR :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GuoPhilipse commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632494495


   :) have corrected and added examples in JIRA


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28605: add docs for sql migration-guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632444721


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28605: add docs for sql migration-guide

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632445014


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632639429


   **[Test build #122995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122995/testReport)** for PR 28605 at commit [`2f5b388`](https://github.com/apache/spark/commit/2f5b3880ab297f1ec65b22625346b27a7cb74b83).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28605: [SPARK-31790][DOCS] cast(long as timestamp) show different result between Hive and Spark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28605:
URL: https://github.com/apache/spark/pull/28605#issuecomment-632644587


   **[Test build #122995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122995/testReport)** for PR 28605 at commit [`2f5b388`](https://github.com/apache/spark/commit/2f5b3880ab297f1ec65b22625346b27a7cb74b83).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org