[GitHub] [spark] viirya commented on a change in pull request #25234: [SPARK-28054][SQL][followup] move the bug fix closer to where causes the issue

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #25234: [SPARK-28054][SQL][followup] move the bug fix closer to where causes the issue
URL: https://github.com/apache/spark/pull/25234#discussion_r306346505
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
 ##########
 @@ -83,16 +83,6 @@ private[hive] trait SaveAsHiveFile extends DataWritingCommand {
       jobId = java.util.UUID.randomUUID().toString,
       outputPath = outputLocation)
 
-    // SPARK-28054: Hive metastore is not case preserving and keeps partition columns
-    // with lower cased names, Hive will validate the column names in partition spec and
-    // the partition paths. Besides lowercasing the column names in the partition spec,
-    // we also need to lowercase the column names in written partition paths.
-    // scalastyle:off caselocale
-    val hiveCompatiblePartitionColumns = partitionAttributes.map { attr =>
-      attr.withName(attr.name.toLowerCase)
-    }
-    // scalastyle:on caselocale
-
 
 Review comment:
   This move looks good. And we should use `partitionAttributes` below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org