You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/06/19 02:27:00 UTC

[jira] [Updated] (ARROW-5549) [C++][Docs] Summarize function argument type guidelines in developers/cpp.rst

     [ https://issues.apache.org/jira/browse/ARROW-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney updated ARROW-5549:
--------------------------------
    Fix Version/s:     (was: 0.14.0)
                   1.0.0

> [C++][Docs] Summarize function argument type guidelines in developers/cpp.rst
> -----------------------------------------------------------------------------
>
>                 Key: ARROW-5549
>                 URL: https://issues.apache.org/jira/browse/ARROW-5549
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>             Fix For: 1.0.0
>
>
> We have a number of spoken and unspoken guidelines around argument passing -- some of them are codified in the Google style guide while others (e.g. use of smart pointers as function arguments) are applied via convention and enforced in code reviews. 
> I propose to add a section to make each case explicit so that our code can become more hygienic and our code reviews less intense



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)