You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/14 04:29:43 UTC

[GitHub] [echarts] pissang opened a new issue #14666: Remove canvas from devDependency in package.json

pissang opened a new issue #14666:
URL: https://github.com/apache/echarts/issues/14666


   I think we should remove node-canvas from devDependency in package.json. I saw many fails on the step installing node-canvas when `npm i`. 
   
   It's currently used in the unit test. We can mock canvas API to replace it.
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang closed issue #14666: Remove canvas from devDependency in package.json

Posted by GitBox <gi...@apache.org>.
pissang closed issue #14666:
URL: https://github.com/apache/echarts/issues/14666


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang edited a comment on issue #14666: Remove canvas from devDependency in package.json

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14666:
URL: https://github.com/apache/echarts/issues/14666#issuecomment-819233009


   @100pah It's not good if we want to run unit tests frequently. Especially when running the tests in the CI environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang edited a comment on issue #14666: Remove canvas from devDependency in package.json

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14666:
URL: https://github.com/apache/echarts/issues/14666#issuecomment-819233009


   @100pah It's not good for running the tests in the CI environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] 100pah commented on issue #14666: Remove canvas from devDependency in package.json

Posted by GitBox <gi...@apache.org>.
100pah commented on issue #14666:
URL: https://github.com/apache/echarts/issues/14666#issuecomment-819222606


   Can be like puppeteer. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on issue #14666: Remove canvas from devDependency in package.json

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14666:
URL: https://github.com/apache/echarts/issues/14666#issuecomment-819233009


   @100pah It's not good for running the tests in the CI environment. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang edited a comment on issue #14666: Remove canvas from devDependency in package.json

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14666:
URL: https://github.com/apache/echarts/issues/14666#issuecomment-819233009


   @100pah It's not convenient if we want to run unit tests frequently. Especially when running the tests in the CI environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org