You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/06 17:57:00 UTC

[jira] [Commented] (AIRFLOW-5824) Add a new hook and operator for AWS DataSync

    [ https://issues.apache.org/jira/browse/AIRFLOW-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968560#comment-16968560 ] 

ASF GitHub Bot commented on AIRFLOW-5824:
-----------------------------------------

baolsen commented on pull request #6512: [AIRFLOW-5824] Added AWS DataSync Hook and Operator
URL: https://github.com/apache/airflow/pull/6512
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     
   ### Description
   - [x] Here are some details about my PR:
   
   Added AWS DataSync Hook and Operator, along with appropriate tests and documentation.
   
   ### Tests
   - [x] My PR adds the following unit tests:
   
   Tests added for both new components (DataSync hook + operator).
   
   The tests require the moto Python library, specifically moto_datasync. 
   I only recently added moto_datasync to moto, so the Airflow tests for AWS DataSync will be skipped if moto_datasync is not present. 
   However all tests pass on my local copy of moto which includes moto_datasync
   
   
   ### Commits
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add a new hook and operator for AWS DataSync
> --------------------------------------------
>
>                 Key: AIRFLOW-5824
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5824
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: aws
>    Affects Versions: 1.10.5
>            Reporter: Bjorn Olsen
>            Assignee: Bjorn Olsen
>            Priority: Minor
>
> I'm working on some code to add a hook and operator for AWS DataSync task executions.
> Just creating a Jira ticket for visibility



--
This message was sent by Atlassian Jira
(v8.3.4#803005)