[GitHub] [hudi] leesf edited a comment on pull request #1647: [HUDI-867]: fixed IllegalArgumentException from graphite metrics in deltaStreamer continuous mode

[GitBox <gi...@apache.org>]

leesf edited a comment on pull request #1647:
URL: https://github.com/apache/hudi/pull/1647#issuecomment-640034374


   > @pratyakshsharma IIUC, this will introduce infinite number of metrics being sent to monitoring system in theory when it's set to continuous mode? Normally for a Hudi table, we'd like to monitor all kinds of metrics named like `<prefix>.<hudi table>.*`, and aggregate over `<prefix>.<hudi table>.<a fixed hudi metric>` for sum, avg, p95, etc. If metric name becomes `<prefix>.<hudi table>_i.<a fixed hudi metric>`, then the aggregation is not possible, which is undesirable.
   > 
   > Haven't thought about the solution yet. Just trying to raise the concern.
   > cc @leesf
   
   Thanks @xushiyan for your thoughts, yes, current solution will send metrics like `<prefix>.<hudi table>_i.<a fixed hudi metric>`, is it suitable to change to `<prefix>.<hudi table>.<i>.<a fixed hudi metric>`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org