[jira] [Commented] (GEODE-2175) CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733632#comment-15733632 ] 

ASF subversion and git services commented on GEODE-2175:
--------------------------------------------------------

Commit 1d951e334334393c2052307988a21c1cd1f11985 in geode's branch refs/heads/develop from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1d951e3 ]

GEODE-2175: wait for results from other members is not needed in result collector. It's already handled by Function framework.


> CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime
> -----------------------------------------------------------------------------
>
>                 Key: GEODE-2175
>                 URL: https://issues.apache.org/jira/browse/GEODE-2175
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Dan Smith
>            Assignee: xiaojian zhou
>
> {noformat}
> org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest > expectErrorAfterWaitTime FAILED
>     java.lang.Exception: Unexpected exception, expected<org.apache.geode.cache.execute.FunctionException> but was<java.lang.AssertionError>
>         Caused by:
>         java.lang.AssertionError: expected:<1> but was:<0>
>             at org.junit.Assert.fail(Assert.java:88)
>             at org.junit.Assert.failNotEquals(Assert.java:834)
>             at org.junit.Assert.assertEquals(Assert.java:645)
>             at org.junit.Assert.assertEquals(Assert.java:631)
>             at org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime(TopEntriesFunctionCollectorJUnitTest.java:195)
> {noformat}
> Looking at this test, it looks like it's a race condition waiting to happen because it does a bunch of 1 second awaits.
> I'm also suspicious of the functionality that is being tested here in the first place. A user's result collector shouldn't have to contain logic to wait for all of the results to be gather, that's handled by the function execution framework. So the real fix may be to remove these tests and the logic in TopEntriesFunctionCollector that waits for the results to be gathered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)