You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 19:04:41 UTC

[GitHub] [airflow] mik-laj commented on pull request #23326: Google provider: Remove `bigquery_conn_id`, `google_cloud_storage_conn_id`

mik-laj commented on PR #23326:
URL: https://github.com/apache/airflow/pull/23326#issuecomment-1112558883

   ```
   $ git ls-files  -z | xargs -0 grep bigquery_conn_id
   grep: .github/actions/checks-action: Is a directory
   grep: .github/actions/codecov-action: Is a directory
   grep: .github/actions/configure-aws-credentials: Is a directory
   grep: .github/actions/get-workflow-origin: Is a directory
   grep: .github/actions/github-push-action: Is a directory
   grep: .github/actions/label-when-approved-action: Is a directory
   RELEASE_NOTES.rst:which apply to most services. Parameters like ``datastore_conn_id``\ , ``bigquery_conn_id``\ ,
   airflow/providers/google/CHANGELOG.rst:* ``bigquery_conn_id`` is removed. Please use ``gcp_conn_id``.
   airflow/providers/google/cloud/operators/bigquery.py:    :param bigquery_conn_id: [Optional] The connection ID used to connect to Google Cloud and
   airflow/providers/google/cloud/operators/bigquery.py:                bigquery_conn_id='airflow-conn-id',
   airflow/providers/google/cloud/operators/bigquery.py:                bigquery_conn_id='airflow-conn-id-account',
   airflow/providers/google/cloud/operators/bigquery.py:        bigquery_conn_id: str = 'google_cloud_default',
   airflow/providers/google/cloud/operators/bigquery.py:        self.bigquery_conn_id = bigquery_conn_id
   airflow/providers/google/cloud/operators/bigquery.py:            gcp_conn_id=self.bigquery_conn_id,
   airflow/providers/google/cloud/operators/bigquery.py:    :param bigquery_conn_id: (Optional) The connection ID used to connect to Google Cloud and
   airflow/providers/google/cloud/operators/bigquery.py:        bigquery_conn_id: str = 'google_cloud_default',
   airflow/providers/google/cloud/operators/bigquery.py:        self.bigquery_conn_id = bigquery_conn_id
   airflow/providers/google/cloud/operators/bigquery.py:            gcp_conn_id=self.bigquery_conn_id,
   airflow/providers/google/cloud/operators/bigquery.py:    :param bigquery_conn_id: (Deprecated) The connection ID used to connect to Google Cloud.
   grep: provider_packages/dist: Is a directory
   $ git ls-files  -z | xargs -0 grep google_cloud_storage_conn_id
   grep: .github/actions/checks-action: Is a directory
   grep: .github/actions/codecov-action: Is a directory
   grep: .github/actions/configure-aws-credentials: Is a directory
   grep: .github/actions/get-workflow-origin: Is a directory
   grep: .github/actions/github-push-action: Is a directory
   grep: .github/actions/label-when-approved-action: Is a directory
   RELEASE_NOTES.rst:``google_cloud_storage_conn_id`` and similar have been deprecated. Operators that require two connections are not changed.
   airflow/providers/amazon/aws/transfers/gcs_to_s3.py:    :param google_cloud_storage_conn_id: (Deprecated) The connection ID used to connect to Google Cloud.
   airflow/providers/amazon/aws/transfers/gcs_to_s3.py:        google_cloud_storage_conn_id: Optional[str] = None,
   airflow/providers/amazon/aws/transfers/gcs_to_s3.py:        if google_cloud_storage_conn_id:
   airflow/providers/amazon/aws/transfers/gcs_to_s3.py:                "The google_cloud_storage_conn_id parameter has been deprecated. You should pass "
   airflow/providers/amazon/aws/transfers/gcs_to_s3.py:            gcp_conn_id = google_cloud_storage_conn_id
   airflow/providers/google/CHANGELOG.rst:* ``google_cloud_storage_conn_id`` is removed. Please use ``gcp_conn_id``.
   airflow/providers/google/CHANGELOG.rst:* ``Replace 'google_cloud_storage_conn_id' by 'gcp_conn_id' when using 'GCSHook' (#13851)``
   airflow/providers/google/cloud/operators/bigquery.py:    :param google_cloud_storage_conn_id: [Optional] The connection ID used to connect to Google Cloud.
   airflow/providers/google/cloud/operators/bigquery.py:                google_cloud_storage_conn_id='airflow-conn-id'
   airflow/providers/google/cloud/operators/bigquery.py:                google_cloud_storage_conn_id='airflow-conn-id'
   airflow/providers/google/cloud/operators/bigquery.py:        google_cloud_storage_conn_id: str = 'google_cloud_default',
   airflow/providers/google/cloud/operators/bigquery.py:        self.google_cloud_storage_conn_id = google_cloud_storage_conn_id
   airflow/providers/google/cloud/operators/bigquery.py:                gcp_conn_id=self.google_cloud_storage_conn_id,
   airflow/providers/google/cloud/operators/bigquery.py:    :param google_cloud_storage_conn_id: (Optional) The connection ID used to connect to Google Cloud
   airflow/providers/google/cloud/operators/bigquery.py:        google_cloud_storage_conn_id: str = 'google_cloud_default',
   airflow/providers/google/cloud/operators/bigquery.py:        self.google_cloud_storage_conn_id = google_cloud_storage_conn_id
   airflow/providers/google/cloud/operators/bigquery.py:                gcp_conn_id=self.google_cloud_storage_conn_id,
   docs/apache-airflow-providers-amazon/commits.rst:`f473ca7130 <https://github.com/apache/airflow/commit/f473ca7130f844bc59477674e641b42b80698bb7>`_  2021-01-24   ``Replace 'google_cloud_storage_conn_id' by 'gcp_conn_id' when using 'GCSHook' (#13851)``
   docs/apache-airflow-providers-google/commits.rst:`f473ca7130 <https://github.com/apache/airflow/commit/f473ca7130f844bc59477674e641b42b80698bb7>`_  2021-01-24   ``Replace 'google_cloud_storage_conn_id' by 'gcp_conn_id' when using 'GCSHook' (#13851)``
   grep: provider_packages/dist: Is a directory
   ```
   Can you check `airflow/providers/google/cloud/operators/bigquery.py`, `airflow/providers/amazon/aws/transfers/gcs_to_s3.py` files?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org