[GitHub] [hive] maheshrajus commented on a diff in pull request #4174: HIVE-27198: Delete aborted transactions directly instead of select and loading ids

["maheshrajus (via GitHub)" <gi...@apache.org>]

maheshrajus commented on code in PR #4174:
URL: https://github.com/apache/hive/pull/4174#discussion_r1182127027


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -875,7 +875,6 @@ public void cleanEmptyAbortedAndCommittedTxns() throws MetaException {
     try {
       Connection dbConn = null;
       Statement stmt = null;
-      ResultSet rs = null;

Review Comment:
   Hi @deniskuzZ thx for review. 
   we are not just closing the db  connection in finally block, we are doing rollback in catch block(        rollbackDBConn(dbConn)).
   I think try-with-resource may not work in this case. So i am keeping try block code only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org