You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "utkarsharma2 (via GitHub)" <gi...@apache.org> on 2023/09/27 10:40:27 UTC
[GitHub] [airflow] utkarsharma2 opened a new pull request, #34647: Move cli's Connection export and Variable export command print logic to a seprate function
utkarsharma2 opened a new pull request, #34647:
URL: https://github.com/apache/airflow/pull/34647
related: https://github.com/apache/airflow/pull/34640
This PR attempts to move the output logic for `airflow connection export` and `airflow variable export` to a separate function to ensure they don't unknowingly change in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #34647: Move cli's Connection export and Variable export command print logic to a seprate function
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #34647:
URL: https://github.com/apache/airflow/pull/34647#issuecomment-1737728724
@utkarsharma2, it lives here now: https://github.com/apache/airflow/blob/fb92ff8486f21b61a840ddc4414429c3a9adfc88/airflow/auth/managers/fab/cli_commands/user_command.py#L153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #34647:
URL: https://github.com/apache/airflow/pull/34647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #34647:
URL: https://github.com/apache/airflow/pull/34647#discussion_r1345419393
##########
airflow/cli/utils.py:
##########
@@ -40,3 +40,10 @@ def is_stdout(fileio: IOBase) -> bool:
.. warning:: *fileio* must be open for this check to be successful.
"""
return fileio.fileno() == sys.stdout.fileno()
+
+
+def print_export_output(command_type: str, exported_items: Collection, file_is_stdout: bool, file_path: str):
Review Comment:
It would be better to simply pass in the file object as an argument and calculate both values here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #34647:
URL: https://github.com/apache/airflow/pull/34647#issuecomment-1750553531
@uranusjr The failure on the PR don't look related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on code in PR #34647:
URL: https://github.com/apache/airflow/pull/34647#discussion_r1348646994
##########
airflow/cli/utils.py:
##########
@@ -40,3 +40,10 @@ def is_stdout(fileio: IOBase) -> bool:
.. warning:: *fileio* must be open for this check to be successful.
"""
return fileio.fileno() == sys.stdout.fileno()
+
+
+def print_export_output(command_type: str, exported_items: Collection, file_is_stdout: bool, file_path: str):
Review Comment:
@uranusjr Updated the code to reflect the suggestions, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #34647:
URL: https://github.com/apache/airflow/pull/34647#issuecomment-1766281868
> @uranusjr The failure on the PR don't look related.
please rebase and lets see how it looks now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #34647:
URL: https://github.com/apache/airflow/pull/34647#issuecomment-1766446484
@eladkal All checks are passing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] utkarsharma2 commented on pull request #34647: Move cli's Connection export and Variable export command print logic to a seprate function
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #34647:
URL: https://github.com/apache/airflow/pull/34647#issuecomment-1737147423
cc: @hussein-awala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org