You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2023/10/28 00:29:46 UTC
[I] Introduce return_data_type for Aggregate function [arrow-datafusion]
jayzhan211 opened a new issue, #7960:
URL: https://github.com/apache/arrow-datafusion/issues/7960
### Is your feature request related to a problem or challenge?
return_data_type is not the same as the data_type for List case. For example, data_type: List(Int64), return_data_type will be Int64
Ref: https://github.com/apache/arrow-datafusion/pull/7242/files
### Describe the solution you'd like
Introduce return_data_type for Sum, and other Aggregate function
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Introduce return_data_type for Aggregate function [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #7960:
URL: https://github.com/apache/arrow-datafusion/issues/7960#issuecomment-1784081531
I think we should do some more careful thinking of how to handle multi-phase aggregates where the intermediate type is not the same as the output type -- for example `SUM(x)` for non lists can use the same aggregate (as you can sum partial sums) but `COUNT(x)` does not -- the first phase must actually COUNT but the second needs to use SUM.
This causes problems for #6937 where we might want to dynamically stop doing the first phase aggregation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Introduce return_data_type for Aggregate function [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on issue #7960:
URL: https://github.com/apache/datafusion/issues/7960#issuecomment-2161881286
Reopen it if there is any concrete issue to solve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Introduce return_data_type for Aggregate function [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 closed issue #7960: Introduce return_data_type for Aggregate function
URL: https://github.com/apache/datafusion/issues/7960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Introduce return_data_type for Aggregate function [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on issue #7960:
URL: https://github.com/apache/arrow-datafusion/issues/7960#issuecomment-1806992839
TODO
- [ ] min_max
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org