[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1331: [CELEBORN-410] Change source name use upper case

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on PR #1331:
URL: https://github.com/apache/incubator-celeborn/pull/1331#issuecomment-1465787030

   I'm not sure if we should change the constants to upper case with under scores separating words, because that's Java's convention. In scala the convention is to use camel case with first letter upper case. Below is the reference from <Programming in Scala> 2nd edition, page 152
   ```
   In Java, the convention is to give constants names that are all upper case, with underscores
   separating the words, such as MAX_VALUE or PI. In Scala, the convention is
   merely that the first character should be upper case. Thus, constants named
   in the Java style, such as X_OFFSET, will work as Scala constants, but the
   Scala convention is to use camel case for constants, such as XOffset.
   ```
   
   And I find spark don't even use upper case for the first letter, for example


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org