You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/12 21:18:27 UTC
[GitHub] [superset] nytai commented on a change in pull request #13087: perf: add lazy loading along react-router routes and router links in menu
nytai commented on a change in pull request #13087:
URL: https://github.com/apache/superset/pull/13087#discussion_r575524565
##########
File path: superset-frontend/src/views/App.tsx
##########
@@ -77,79 +155,81 @@ const App = () => (
ReactRouterRoute={Route}
stringifyOptions={{ encode: false }}
>
- <Menu data={menu} />
- <Switch>
- <Route path="/superset/welcome/">
- <ErrorBoundary>
- <Welcome user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/dashboard/list/">
- <ErrorBoundary>
- <DashboardList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/chart/list/">
- <ErrorBoundary>
- <ChartList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/tablemodelview/list/">
- <ErrorBoundary>
- <DatasetList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/databaseview/list/">
- <ErrorBoundary>
- <DatabaseList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/savedqueryview/list/">
- <ErrorBoundary>
- <SavedQueryList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/csstemplatemodelview/list/">
- <ErrorBoundary>
- <CssTemplatesList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/annotationlayermodelview/list/">
- <ErrorBoundary>
- <AnnotationLayersList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/annotationmodelview/:annotationLayerId/annotation/">
- <ErrorBoundary>
- <AnnotationList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/superset/sqllab/history/">
- <ErrorBoundary>
- <QueryList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/alert/list/">
- <ErrorBoundary>
- <AlertList user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/report/list/">
- <ErrorBoundary>
- <AlertList user={user} isReportEnabled />
- </ErrorBoundary>
- </Route>
- <Route path="/alert/:alertId/log">
- <ErrorBoundary>
- <ExecutionLog user={user} />
- </ErrorBoundary>
- </Route>
- <Route path="/report/:alertId/log">
- <ErrorBoundary>
- <ExecutionLog user={user} isReportEnabled />
- </ErrorBoundary>
- </Route>
- </Switch>
+ <Menu data={menu} frontEndRoutes={frontEndRoutes} />
+ <Suspense fallback={<Loading />}>
+ <Switch>
+ <Route path={routes.welcome}>
Review comment:
We could do that, an array might make more sense then, something like `{route: string, component: React.ReactNode}[]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org