You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/09 12:10:50 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #10283: MINOR: KRPC supports to get true type from entity type

chia7712 commented on a change in pull request #10283:
URL: https://github.com/apache/kafka/pull/10283#discussion_r590299752



##########
File path: generator/src/main/java/org/apache/kafka/message/FieldSpec.java
##########
@@ -89,7 +89,12 @@ public FieldSpec(@JsonProperty("name") String name,
         }
         this.fields = Collections.unmodifiableList(fields == null ?
             Collections.emptyList() : new ArrayList<>(fields));
-        this.type = FieldType.parse(Objects.requireNonNull(type));
+        this.entityType = (entityType == null) ? EntityType.UNKNOWN : entityType;

Review comment:
       Good question. This PR does not plan to support that cases as entity type can’t show “array” type. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org