You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by "P. Ottlinger" <po...@apache.org> on 2019/03/21 22:51:04 UTC
Mergerequests for TAMAYA-385: RAT update / Checkstyle everywhere?
Hi,
just to keep the 4-eye-principle up ...
can someone be so kind to do the merges concerning the RAT updates?
On the way I realized that Checkstyle does not seem to be active in all
modules / tests - wouldn't we want that ;)?
I was playing around with new Eclipse and it showed a lot of warnings
about unused imports.
Cheers & thanks,
Phil
Re: Mergerequests for TAMAYA-385: RAT update / Checkstyle everywhere?
Posted by "P. Ottlinger" <po...@apache.org>.
Hi Aaron,
I spotted the error messages as Eclipse warnings .....
let's see if the Sonarintegration is of help once infra enabled it for
Tamaya.
Cheers,
Phil
Am 26.03.19 um 14:32 schrieb Aaron Coburn:
> I don't think Checkstyle is able to identify unused variables. Findbugs
> *should* be able to do this, though when I tried running the analysis
> via `mvn clean verify site`, the report didn't include the unused LOG
> variable in the SupplierConverter class mentioned earlier. In fact,
> nothing was reported from tamaya-core, though it may be that I was
> running the analysis incorrectly. AFAIK, the test code isn't analyzed at
> all by findbugs.
>
> It is also my impression that findbugs is no longer maintained. Perhaps
> it would be worthwhile changing over to spotbugs or PMD? Alternatively,
> once the Sonar integration is set up, that should be able to generate
> reports identifying all the unused variables.
>
> Aaron
>
> On Mon, Mar 25, 2019 at 4:39 PM P. Ottlinger <pottlinger@apache.org
> <ma...@apache.org>> wrote:
Re: Mergerequests for TAMAYA-385: RAT update / Checkstyle everywhere?
Posted by Aaron Coburn <aa...@gmail.com>.
I don't think Checkstyle is able to identify unused variables. Findbugs
*should* be able to do this, though when I tried running the analysis via
`mvn clean verify site`, the report didn't include the unused LOG variable
in the SupplierConverter class mentioned earlier. In fact, nothing was
reported from tamaya-core, though it may be that I was running the analysis
incorrectly. AFAIK, the test code isn't analyzed at all by findbugs.
It is also my impression that findbugs is no longer maintained. Perhaps it
would be worthwhile changing over to spotbugs or PMD? Alternatively, once
the Sonar integration is set up, that should be able to generate reports
identifying all the unused variables.
Aaron
On Mon, Mar 25, 2019 at 4:39 PM P. Ottlinger <po...@apache.org> wrote:
> Hi,
>
> Am 22.03.19 um 05:08 schrieb Aaron Coburn:
> > Which modules don't have checkstyle enabled?
>
> Not sure if it's configured but
> tamaya-core
> has some unused variables, that I'd expect to be marked by Checkstyle.
>
> Is that the case?
>
> e.g.
>
> /tamaya-core/src/main/java/org/apache/tamaya/core/internal/converters/SupplierConverter.java
>
> Tests have multiple unused variables - is that a rule?
>
> Thanks,
> Phil
>
>
Re: Mergerequests for TAMAYA-385: RAT update / Checkstyle everywhere?
Posted by "P. Ottlinger" <po...@apache.org>.
Hi,
Am 22.03.19 um 05:08 schrieb Aaron Coburn:
> Which modules don't have checkstyle enabled?
Not sure if it's configured but
tamaya-core
has some unused variables, that I'd expect to be marked by Checkstyle.
Is that the case?
e.g.
/tamaya-core/src/main/java/org/apache/tamaya/core/internal/converters/SupplierConverter.java
Tests have multiple unused variables - is that a rule?
Thanks,
Phil
Re: Mergerequests for TAMAYA-385: RAT update / Checkstyle everywhere?
Posted by Aaron Coburn <aa...@gmail.com>.
Thanks for the nudge. I just merged these pull requests.
Which modules don't have checkstyle enabled?
Best,
Aaron
On Thu, Mar 21, 2019 at 7:32 PM Anatole Tresch <at...@gmail.com> wrote:
> I would love to do so, but I am currently in Spain St a vom Land Event. I
> can do it in Monday the earliest...
>
> P. Ottlinger <po...@apache.org> schrieb am Do., 21. März 2019, 23:59:
>
> > Hi,
> >
> > just to keep the 4-eye-principle up ...
> > can someone be so kind to do the merges concerning the RAT updates?
> >
> > On the way I realized that Checkstyle does not seem to be active in all
> > modules / tests - wouldn't we want that ;)?
> > I was playing around with new Eclipse and it showed a lot of warnings
> > about unused imports.
> >
> > Cheers & thanks,
> > Phil
> >
>
Re: Mergerequests for TAMAYA-385: RAT update / Checkstyle everywhere?
Posted by Anatole Tresch <at...@gmail.com>.
I would love to do so, but I am currently in Spain St a vom Land Event. I
can do it in Monday the earliest...
P. Ottlinger <po...@apache.org> schrieb am Do., 21. März 2019, 23:59:
> Hi,
>
> just to keep the 4-eye-principle up ...
> can someone be so kind to do the merges concerning the RAT updates?
>
> On the way I realized that Checkstyle does not seem to be active in all
> modules / tests - wouldn't we want that ;)?
> I was playing around with new Eclipse and it showed a lot of warnings
> about unused imports.
>
> Cheers & thanks,
> Phil
>